Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Over button can overlap text with ?stringTest=dynamic #128

Closed
Nancy-Salpepi opened this issue Apr 18, 2024 · 3 comments
Closed

Start Over button can overlap text with ?stringTest=dynamic #128

Nancy-Salpepi opened this issue Apr 18, 2024 · 3 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
14.4.1

Browser
Safari 17.4.1

Problem description
Seen during phetsims/qa#1066 and phetsims/qa#1067: If I make the screen smaller when the strings are long, the Start Over button will overlap the time.

Steps to reproduce

  1. In Graphing Lines or Graphing Slope-Intercept add ?stringTest=dynamic to the end of the url
  2. Go to any game level and press the right arrow key 3 times
  3. Grab the right side of the window and make the screen smaller

Visuals

StartOverCoversTime.mp4
@pixelzoom
Copy link
Contributor

At first I could not reproduce this. Then I realized that the time display needs to be enabled.

pixelzoom added a commit that referenced this issue Apr 19, 2024
pixelzoom added a commit that referenced this issue Apr 19, 2024
pixelzoom added a commit to phetsims/graphing-lines that referenced this issue Apr 19, 2024
pixelzoom added a commit that referenced this issue Apr 19, 2024
pixelzoom added a commit to phetsims/graphing-slope-intercept that referenced this issue Apr 19, 2024
@pixelzoom
Copy link
Contributor

Fixed in 979da81 (maxWidth needed to be set dynamically). Cherry picked to graphing-lines 1.4 and graphing-slope-intercept 1.2.

@Nancy-Salpepi would you please verify in master? If it looks OK, you may close this issue. We'll verify for RC2 in phetsims/graphing-lines#159.

@Nancy-Salpepi
Copy link
Author

At first I could not reproduce this. Then I realized that the time display needs to be enabled.

Sorry about that!

All looks fixed in main. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants