document or remove ts-expect-errors in utterance-queue, see phetsims/…

…chipper#1366
phetsims · Dec 8, 2022 · 93ca6f4 · 93ca6f4
1 parent 3d11438
commit 93ca6f4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/js/SpeechSynthesisParentPolyfill.ts b/js/SpeechSynthesisParentPolyfill.ts
@@ -25,13 +25,13 @@ const SpeechSynthesisParentPolyfill = {
 
     assert && assert( window.parent, 'This polyfill requires a parent frame implementation of SpeechSynthesis.' );
 
-    // @ts-expect-error - Don't judge me TypeScript...
+    // @ts-expect-error - Very hacky, this prototype solution is not getting work anymore. No need for better solution.
     window.SpeechSynthesis = window.parent.SpeechSynthesis;
 
-    // @ts-expect-error - Don't judge me TypeScript...
+    // @ts-expect-error - Very hacky, this prototype solution is not getting work anymore. No need for better solution.
     window.speechSynthesis = new window.parent.SpeechSynthesis();
 
-    // @ts-expect-error - Don't judge me TypeScript...
+    // @ts-expect-error - Very hacky, this prototype solution is not getting work anymore. No need for better solution.
     window.SpeechSynthesisUtterance = window.parent.SpeechSynthesisUtterance;
   }
 };

diff --git a/js/Utterance.ts b/js/Utterance.ts
@@ -363,8 +363,9 @@ class Utterance extends Disposable implements FeatureSpecificAnnouncingControlPr
       alert = alertable.value;
     }
     else {
-      // @ts-expect-error
-      alert = alertable;
+
+      // Nothing to process from the TAlertable, it is raw content
+      alert = alertable as ResolvedResponse;
     }
     return alert;
   }

diff --git a/js/utterance-queue-main.ts b/js/utterance-queue-main.ts
@@ -7,12 +7,12 @@ import utteranceQueue from './main.js'; // eslint-disable-line default-import-ma
 ( function() {
 
 
-  // @ts-expect-error
+  // @ts-expect-error - Assigning to window to support standalone build.
   window.axon = axon;
 
-  // @ts-expect-error
+  // @ts-expect-error - Assigning to window to support standalone build.
   window.phetCore = phetCore;
 
-  // @ts-expect-error
+  // @ts-expect-error - Assigning to window to support standalone build.
   window.utteranceQueue = utteranceQueue;
 } );