Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise implementation-notes.md #66

Closed
pixelzoom opened this issue Oct 3, 2016 · 6 comments
Closed

revise implementation-notes.md #66

pixelzoom opened this issue Oct 3, 2016 · 6 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Oct 3, 2016

Code review #52.

Deficiencies in implementation-notes.md:

(1) Some of the entries would be more appropriate as GitHub issues, since they describe unresolved issues (e.g. potential memory leaks)

(2) There is a heading for the "Racing Lab" screen, but no information.

(3) Not much of an "overview" is gleaned by reading this, which is the main purpose of the file.

Whoever finishes off this sim should revisit and revise this file.

@pixelzoom
Copy link
Contributor Author

Also recommended to add a Terminology section to implementation-notes.md.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jan 24, 2017

Check list of things that implementation-notes.md should contain or mention for this sim:

  • terminology
  • there is no model-view transform (single coordinate frame)
  • issues related to rounding and number of decimal places
  • use of pattern for nested options

pixelzoom added a commit that referenced this issue Feb 26, 2017
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Mar 6, 2017

Most complicated bits:

  • markerEditorObserver` in DoubleNumberLineAccordionBox
  • BagDragHandler and ShoppingItemDragHandler
  • ShoppingItemContainer (bagRow, backItemRow, frontItemRow)
  • ShoppingQuestionFactory
  • Creation and management of bags and items

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Mar 6, 2017

  • Terminology:
    • marker
    • marker editor
    • track marker
    • rate
    • numerator
    • denominator
    • item row, bag row, cell

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Mar 6, 2017

Model hierarchy for shopping screens:

  • ShoppingItemData

  • ShoppingScene (FruitScene, VegetableScene, CandyScene)

  • ShoppingContainer (Shelf, Scale)

pixelzoom added a commit that referenced this issue Mar 6, 2017
pixelzoom added a commit that referenced this issue Mar 6, 2017
pixelzoom added a commit that referenced this issue Mar 6, 2017
pixelzoom added a commit that referenced this issue Mar 6, 2017
pixelzoom added a commit that referenced this issue Mar 6, 2017
pixelzoom added a commit that referenced this issue Mar 7, 2017
pixelzoom added a commit that referenced this issue Mar 7, 2017
pixelzoom added a commit that referenced this issue Mar 7, 2017
pixelzoom added a commit that referenced this issue Mar 7, 2017
pixelzoom added a commit that referenced this issue Mar 7, 2017
pixelzoom added a commit that referenced this issue Mar 7, 2017
pixelzoom added a commit that referenced this issue Mar 7, 2017
@pixelzoom
Copy link
Contributor Author

Done, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant