Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing doc/ files #62

Closed
pixelzoom opened this issue Oct 3, 2016 · 1 comment
Closed

missing doc/ files #62

pixelzoom opened this issue Oct 3, 2016 · 1 comment
Assignees
@pixelzoom
Labels
dev:code-review

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Oct 3, 2016 •
edited
Loading

Code review #52.

Sim fails this item:

  • Are all required files and directories present?

because:

(1) implementation-notes.md is at the top level (instead of in doc/)
(2) there is no model.md
pixelzoom added a commit that referenced this issue Oct 3, 2016
@pixelzoom
move implementation-notes.md to doc/, #62
d2b22bd
@pixelzoom pixelzoom self-assigned this Oct 3, 2016
@pixelzoom pixelzoom mentioned this issue Oct 3, 2016
Closed
@pixelzoom
Copy link
Contributor Author

Tracking missing model.md in #65. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom