Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion Panels on Racing Lab screen have slightly different heights #233

Open
Nancy-Salpepi opened this issue Oct 10, 2024 · 2 comments
Open

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
15.0

Browser
Safari 18.0

Problem description
For phetsims/qa#1151, this is a minor thing (but I am Type A): on the Racing Lab Screen I noticed that the panel heights no longer match like they do in published.

Visuals
Screenshot 2024-10-10 at 11 04 00 AM

published:
Screenshot 2024-10-10 at 11 04 14 AM

@pixelzoom
Copy link
Contributor

Thanks @Nancy-Salpepi. This was a regression when converting to dynamic layout, worth fixing -- which has been done in main and 1.1 branches. Please review. It it looks OK, change the label to "fixed-awaiting-deploy", for verification in RC2.

@Nancy-Salpepi
Copy link
Author

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants