Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IO Types to the bottom of corresponding core type files (where appropriate) #212

Closed
samreid opened this issue Sep 11, 2020 · 4 comments
Closed

Move IO Types to the bottom of corresponding core type files (where appropriate) #212

samreid opened this issue Sep 11, 2020 · 4 comments
Assignees
@zepumph

Comments

@samreid
Copy link
Member

samreid commented Sep 11, 2020

From #188 (comment)

We prefer to move the IO types to the bottom of the core type file. This makes it possible to set the validator using the exact class without needing to access it lazily or access it from the namespace. I'll make a new issue to move to this pattern.

Note this will not be possible for StringIO or NumberIO. IO Types that are used by multiple core types may wish to remain separate.
@samreid samreid self-assigned this Sep 11, 2020
@samreid
Copy link
Member Author

samreid commented Sep 12, 2020

Let's wait until NS has SHAs and perhaps wait until there is progress in #211 first.

@samreid
Copy link
Member Author

samreid commented Sep 25, 2020

There is sufficient progress in #211, but @zepumph and I are partway through a "what is the long term goal" conversation which may adjust our path. But no matter how that conversation goes, should we still implement this issue now as a stepping stone?

@samreid samreid assigned zepumph and unassigned samreid Sep 25, 2020
@samreid
Copy link
Member Author

samreid commented Sep 26, 2020

We discussed this today and agreed it is best to move new IOType to the core file for now.

samreid added a commit to phetsims/scenery that referenced this issue Sep 29, 2020
@samreid
Move NumberPropertyIO to NumberProperty.js, see phetsims/tandem#212
34259ee
samreid added a commit to phetsims/axon that referenced this issue Sep 29, 2020
@samreid
Move NumberPropertyIO to NumberProperty.js, see phetsims/tandem#212
382dded
samreid added a commit to phetsims/sun that referenced this issue Sep 29, 2020
@samreid
Move ComboBoxIO to ComboBox.js, see phetsims/tandem#212
a9d56ca
samreid added a commit to phetsims/wave-on-a-string that referenced this issue Sep 29, 2020
@samreid
Move IO Type to core file, see phetsims/tandem#212
f86ee6f
samreid added a commit to phetsims/axon that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
b24f9dc
samreid added a commit to phetsims/balloons-and-static-electricity that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
63fa41b
samreid added a commit to phetsims/beers-law-lab that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
89e3a77
samreid added a commit to phetsims/bending-light that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
70c9602
samreid added a commit to phetsims/blackbody-spectrum that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
2f4917c
samreid added a commit to phetsims/build-an-atom that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
2681814
samreid added a commit to phetsims/capacitor-lab-basics that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
4a7dd57
samreid added a commit to phetsims/charges-and-fields that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
8e72b42
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
2324b59
samreid added a commit to phetsims/color-vision that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
9d0f67d
samreid added a commit to phetsims/dot that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
9a5af19
samreid added a commit to phetsims/energy-forms-and-changes that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
e738586
samreid added a commit to phetsims/energy-skate-park that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
12d2feb
samreid added a commit to phetsims/faradays-law that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
073c6d4
samreid added a commit to phetsims/forces-and-motion-basics that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
487f45d
samreid added a commit to phetsims/gas-properties that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
64b14af
samreid added a commit to phetsims/graphing-quadratics that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
4109458
samreid added a commit to phetsims/gravity-and-orbits that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
60820b4
samreid added a commit to phetsims/inverse-square-law-common that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
e17d2b4
samreid added a commit to phetsims/joist that referenced this issue Sep 29, 2020
@samreid
Move PropertyIO to Property.js, see phetsims/tandem#212
c530cb4
samreid added a commit to phetsims/john-travoltage that referenced this issue Sep 30, 2020
@samreid
Use valueType, see phetsims/tandem#212
defcfd5
samreid added a commit to phetsims/masses-and-springs that referenced this issue Sep 30, 2020
@samreid
Use valueType, see phetsims/tandem#212
c260230
samreid added a commit to phetsims/scenery that referenced this issue Sep 30, 2020
@samreid
Use valueType, see phetsims/tandem#212
44e3116
samreid added a commit to phetsims/scenery-phet that referenced this issue Sep 30, 2020
@samreid
Move IO Type to core file, see phetsims/tandem#212
80fcb6e
samreid added a commit to phetsims/balancing-act that referenced this issue Sep 30, 2020
@samreid
Move PhetioGroupIO to PhetioGroup.js, see phetsims/tandem#212
dd70823
samreid added a commit to phetsims/beers-law-lab that referenced this issue Sep 30, 2020
@samreid
Move PhetioGroupIO to PhetioGroup.js, see phetsims/tandem#212
dc63d59
samreid added a commit to phetsims/charges-and-fields that referenced this issue Sep 30, 2020
@samreid
Move PhetioGroupIO to PhetioGroup.js, see phetsims/tandem#212
db78c3b
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Sep 30, 2020
@samreid
Move PhetioGroupIO to PhetioGroup.js, see phetsims/tandem#212
7f394d3
samreid added a commit to phetsims/energy-forms-and-changes that referenced this issue Sep 30, 2020
@samreid
Move PhetioGroupIO to PhetioGroup.js, see phetsims/tandem#212
20157b1
samreid added a commit to phetsims/john-travoltage that referenced this issue Sep 30, 2020
@samreid
Move PhetioGroupIO to PhetioGroup.js, see phetsims/tandem#212
e8b5561
samreid added a commit to phetsims/joist that referenced this issue Sep 30, 2020
@samreid
Move IO Type to core file, see phetsims/tandem#212
1221971
samreid added a commit to phetsims/molecules-and-light that referenced this issue Sep 30, 2020
@samreid
Move IO Type to core file, see phetsims/tandem#212
39ce331
samreid added a commit to phetsims/natural-selection that referenced this issue Sep 30, 2020
@samreid
Move PhetioGroupIO to PhetioGroup.js, see phetsims/tandem#212
a2a66b0
samreid added a commit to phetsims/projectile-motion that referenced this issue Sep 30, 2020
@samreid
Move PhetioGroupIO to PhetioGroup.js, see phetsims/tandem#212
22cbbee
samreid added a commit that referenced this issue Sep 30, 2020
@samreid
Move IO Type to core file, see #212
2055272
samreid added a commit that referenced this issue Sep 30, 2020
@samreid
Move PhetioGroupIO to PhetioGroup.js, see #212
22a846e
samreid added a commit to phetsims/phet-core that referenced this issue Sep 30, 2020
@samreid
Add TODOs, see phetsims/tandem#212
304095e
@samreid samreid mentioned this issue Sep 30, 2020
Closed
samreid added a commit to phetsims/phet-core that referenced this issue Sep 30, 2020
@samreid
Eliminate completed TODO, see phetsims/tandem#212
5082e52
samreid added a commit to phetsims/phet-core that referenced this issue Sep 30, 2020
@samreid
Documentation, see phetsims/tandem#212
0911297
samreid added a commit to phetsims/phet-core that referenced this issue Sep 30, 2020
@samreid
Documentation, see phetsims/tandem#212
af9a1d3
@samreid
Copy link
Member Author

samreid commented Sep 30, 2020

I moved the appropriate IO types to the core type files. All TODOs complete. Closing.

@samreid samreid closed this as completed Sep 30, 2020
@samreid samreid mentioned this issue Sep 30, 2020
Closed
samreid added a commit to phetsims/utterance-queue that referenced this issue Sep 30, 2020
@samreid
Remove broken import, see phetsims/tandem#212
7d9c1fb
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
@samreid @jessegreenberg
Move PropertyIO to Property.js, see phetsims/tandem#212
8452a5d
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
@samreid @jessegreenberg
Move IO Type to core file, see phetsims/tandem#212
006adbb
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
@samreid @jessegreenberg
Move IO Type to core file, see phetsims/tandem#212
ccee40a
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
@samreid @jessegreenberg
Move IO Type to core file, see phetsims/tandem#212
a168324
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
@samreid @jessegreenberg
Move IO Type to core file, see phetsims/tandem#212
51e4a22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph