Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompositeThermometerNode: opt out of dynamic layout #273

Closed
arouinfar opened this issue May 12, 2020 · 2 comments
Closed

CompositeThermometerNode: opt out of dynamic layout #273

arouinfar opened this issue May 12, 2020 · 2 comments
Assignees
@arouinfar
Labels
design:phet-io

Comments

@arouinfar
Copy link
Contributor

Discovered in #272

When hiding the ComboBox (particleContainerNode.compositeThermometerNode.temperatureComboBox.visibleProperty), the thermometer's position shifts in such a way that it no longer appears to be measuring inside the container.

image
image

This seems related to the support for dynamic layout introduced in phetsims/joist#608. @jbphet can you opt out of this for the CompositeThermomterNode on the States and Phase Changes screens?
jbphet added a commit that referenced this issue May 15, 2020
@jbphet
fixed issue with dynamic layout of thermometer node, see #273
3372034
@jbphet
Copy link
Contributor

jbphet commented May 15, 2020

I fixed this by setting the resize option to false in the VBox in which the thermometer and the combo box are embedded, and it seemed to do the trick. @arouinfar - please check on master and close if it looks good to you.

@jbphet jbphet assigned arouinfar and unassigned jbphet May 15, 2020
@arouinfar
Copy link
Contributor Author

Looks good in master @jbphet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
design:phet-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @arouinfar