Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NO_INTERNET code #399

Closed
liammulh opened this issue Apr 20, 2023 · 1 comment
Closed

Remove NO_INTERNET code #399

liammulh opened this issue Apr 20, 2023 · 1 comment

Comments

@liammulh
Copy link
Member

I added some conditional code that makes it so that I could develop Rosetta without an internet connection. (I was traveling.)

For example:

// If working on the translation utility without an internet connection,
// mock the translation form data with your local copy. (This assumes you have
// a local copy of translation form data.)
if ( publicConfig.ENVIRONMENT === 'development' && privateConfig.NO_INTERNET ) {
logger.info( 'using local copy of translation form data' );
return JSON.parse( fs.readFileSync( './translationFormData.json' ) );
}

I don't think it's necessary to keep this code around. I think we could do a project-wide search on NO_INTERNET and remove the conditional blocks that use that variable, and then remove the variable from the config.

liammulh added a commit that referenced this issue Apr 28, 2023
@liammulh
Copy link
Member Author

Deployed in 6021626 (2.0.7).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant