Remove unused second arg to RAPConstants.toFixed(), #243

phetsims · Dec 21, 2020 · 71e5651 · 71e5651
1 parent 476764c
commit 71e5651
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/js/common/model/RAPModelTests.js b/js/common/model/RAPModelTests.js
@@ -40,7 +40,7 @@ QUnit.test( 'keyboard input to model always can get in proportion: 2/7 moving do
 
   newValue = snapConserveFunction( .11, ratioTupleProperty.value.antecedent, true );
   ratioTupleProperty.value.antecedent = newValue;
-  const idealRatio = RAPConstants.toFixed( model.targetRatioProperty.value * ratioTupleProperty.value.consequent, 6 ); // to prevent rounding errors
+  const idealRatio = RAPConstants.toFixed( model.targetRatioProperty.value * ratioTupleProperty.value.consequent ); // to prevent rounding errors
   assert.ok( ratioTupleProperty.value.antecedent === idealRatio, 'another step down should snap to in proportion' );
 
   newValue = snapConserveFunction( ratioTupleProperty.value.antecedent - .01, ratioTupleProperty.value.antecedent, true );
@@ -74,7 +74,7 @@ QUnit.test( 'keyboard always can get in proportion: 2/7 moving up', assert => {
 
   newValue = snapConserveFunction( .12, ratioTupleProperty.value.antecedent, true );
   ratioTupleProperty.value.antecedent = newValue;
-  const idealAntecedent = RAPConstants.toFixed( model.targetRatioProperty.value * ratioTupleProperty.value.consequent, 6 ); // to prevent rounding errors
+  const idealAntecedent = RAPConstants.toFixed( model.targetRatioProperty.value * ratioTupleProperty.value.consequent ); // to prevent rounding errors
   assert.ok( ratioTupleProperty.value.antecedent === idealAntecedent, 'step up through ideal' );
 
   newValue = snapConserveFunction( ratioTupleProperty.value.antecedent + .01, ratioTupleProperty.value.antecedent, true );

diff --git a/js/common/view/describers/TickMarkDescriber.js b/js/common/view/describers/TickMarkDescriber.js
@@ -76,10 +76,10 @@ class TickMarkDescriber {
     const numberOfTickMarks = this.tickMarkRangeProperty.value;
 
     // account for javascript rounding error
-    const expandedValue = RAPConstants.toFixed( normalized * numberOfTickMarks, 6 );
+    const expandedValue = RAPConstants.toFixed( normalized * numberOfTickMarks );
 
     // account for javascript rounding error
-    const remainder = RAPConstants.toFixed( expandedValue % 1, 6 );
+    const remainder = RAPConstants.toFixed( expandedValue % 1 );
 
     assert && assert( remainder < 1 && remainder >= 0, 'remainder not in range' );
 

diff --git a/js/common/view/getKeyboardInputSnappingMapper.js b/js/common/view/getKeyboardInputSnappingMapper.js
@@ -27,7 +27,7 @@ function getKeyboardInputSnappingMapper( getIdealValue, keyboardStep, shiftKeybo
 
   const snappingFunction = ( newValue, oldValue, useShiftKeyStep ) => {
     // Don't conserve the snap for page up/down or home/end keys, just basic movement changes.
-    const applyConservationSnap = RAPConstants.toFixed( Math.abs( newValue - oldValue ), 6 ) <= shiftKeyboardStep;
+    const applyConservationSnap = RAPConstants.toFixed( Math.abs( newValue - oldValue ) ) <= shiftKeyboardStep;
 
     if ( remainder === 0 ) {
       const snapToKeyboardStep = useShiftKeyStep ? shiftKeyboardStep : keyboardStep;
@@ -39,9 +39,9 @@ function getKeyboardInputSnappingMapper( getIdealValue, keyboardStep, shiftKeybo
     if ( applyConservationSnap ) {
 
       let returnValue = newValue;
-      const target = RAPConstants.toFixed( getIdealValue(), 6 );
+      const target = RAPConstants.toFixed( getIdealValue() );
       if ( newValue > target !== oldValue > target && oldValue !== target ) {
-        remainder = RAPConstants.toFixed( newValue - target, 6 );
+        remainder = RAPConstants.toFixed( newValue - target );
         returnValue = target;
       }
 
@@ -51,7 +51,7 @@ function getKeyboardInputSnappingMapper( getIdealValue, keyboardStep, shiftKeybo
         returnValue = newValue;
       }
 
-      returnValue = RAPConstants.toFixed( returnValue, 6 );
+      returnValue = RAPConstants.toFixed( returnValue );
       assert && assert( !isNaN( returnValue ) );
 
       return returnValue;