Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Internal Code Review Meta Issue #20

Open
AgustinVallejo opened this issue Sep 2, 2024 · 2 comments
Open

Onboarding Internal Code Review Meta Issue #20

AgustinVallejo opened this issue Sep 2, 2024 · 2 comments
Assignees

Comments

@AgustinVallejo
Copy link
Contributor

I'll be linking anything I find on my code review to this issue.

@AgustinVallejo
Copy link
Contributor Author

For future reference, adding the file sizes here:

  3743 total
   630 ./js/coins/view/CoinExperimentMeasurementArea.ts
   242 ./js/coins/view/CoinsExperimentSceneView.ts
   200 ./js/coins/view/MultiCoinTestBox.ts
   185 ./js/common/model/TwoStateSystemSet.ts
   170 ./js/coins/view/CoinMeasurementHistogram.ts
   163 ./js/coins/view/OutcomeProbabilityControl.ts
   158 ./js/coins/model/CoinsExperimentSceneModel.ts
   156 ./js/coins/view/SmallCoinNode.ts
   151 ./js/common/model/TwoStateSystem.ts
   145 ./js/coins/view/InitialCoinStateSelectorNode.ts
   122 ./js/coins/view/CoinExperimentButtonSet.ts
   114 ./js/coins/view/CoinsScreenView.ts
   113 ./js/coins/view/CoinExperimentPreparationArea.ts
    81 ./js/coins/view/ProbabilityValueControl.ts
    76 ./js/common/view/QuantumMeasurementScreenView.ts
    71 ./js/coins/view/CoinNode.ts
    68 ./js/coins/view/QuantumCoinNode.ts
    63 ./js/coins/model/CoinsModel.ts
    55 ./js/coins/view/PhysicalCoinNode.ts
    52 ./js/coins/view/SceneSectionHeader.ts
    52 ./js/QuantumMeasurementStrings.ts
    47 ./js/quantum-measurement-main.ts
    43 ./js/bloch-sphere/BlochSphereScreen.ts
    42 ./js/coins/view/ProbabilityEquationsNode.ts
    41 ./js/spin/model/SpinModel.ts
    41 ./js/photons/model/PhotonsModel.ts
    41 ./js/bloch-sphere/model/BlochSphereModel.ts
    39 ./js/spin/SpinScreen.ts
    39 ./js/photons/PhotonsScreen.ts
    38 ./js/common/MockupOpacitySlider.ts
    36 ./js/coins/CoinsScreen.ts
    34 ./js/common/QuantumMeasurementColors.ts
    30 ./js/spin/view/SpinScreenView.ts
    30 ./js/photons/view/PhotonsScreenView.ts
    30 ./js/bloch-sphere/view/BlochSphereScreenView.ts
    27 ./js/common/QuantumMeasurementQueryParameters.ts
    26 ./js/coins/model/ExperimentMeasurementState.ts
    25 ./js/common/QuantumMeasurementConstants.ts
    11 ./js/common/model/SystemType.ts
    10 ./js/quantumMeasurement.ts
     9 ./js/coins/model/QuantumCoinStates.ts
     9 ./js/coins/model/PhysicalCoinStates.ts
     7 ./images/spinScreenMockup_png.ts
     7 ./images/photonsScreenMockup_png.ts
     7 ./images/coinsScreenMockup_png.ts
     7 ./images/blochSphereScreenMockup_png.ts

@jbphet
Copy link
Collaborator

jbphet commented Sep 30, 2024

@AgustinVallejo and I just looked through the remaining REVIEW comments that he had added together, and we addressed all but one. The remaining one is related to making the generic type for TwoStateSystemSet more precise, and @AgustinVallejo is going to do some investigation on this.

@jbphet jbphet assigned AgustinVallejo and unassigned jbphet Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants