Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev test: Ratio and Proportion 1.0.0-dev.77 #582

Closed
9 tasks done
zepumph opened this issue Dec 5, 2020 · 14 comments
Closed
9 tasks done

Dev test: Ratio and Proportion 1.0.0-dev.77 #582

zepumph opened this issue Dec 5, 2020 · 14 comments
Assignees
Labels
QA:a11y QA:dev-test Dev test before an RC

Comments

@zepumph
Copy link
Member

zepumph commented Dec 5, 2020

@emily-phet , @terracoda , @Matthew-Moore240, @BLFiedler, @jbphet, ratio-and-proportion/1.0.0-dev.77 is ready for dev testing. This sim is trying to be published in early 2021 Q1, with RC testing later this month. Document issues in https://github.com/phetsims/ratio-and-proportion/issues and link to this
issue. This test is not delayed, but if testing doesn't start for some time, please let me know and I will get you the latest and greatest dev version.

Please note that there are known issues and bugs with this sim, see https://github.com/phetsims/ratio-and-proportion/issues?q=is%3Aissue+is%3Aopen+label%3Atype%3Abug for the current bugs. We wanted to expedite the testing even though these aren't yet fixed to expose as many problems as early as possible.

Assigning @ariel-phet for prioritization.

General Dev Test

What to Test

  • Click every single button.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Try to include browser version numbers
  • If there is a console available, check for errors and include them in the Problem Description.
  • Run through the string tests on at least one platform, especially if it is about to go to rc.
  • Check the Game Up harness on one platform.

Focus and Special Instructions

[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested,
list them here. Any behaviors you want QA to pay special attention to should be listed here.]

General Dev Test Platforms

  • Latest macOS, Chrome and Safari
  • Latest iOS, Safari
  • Windows 10, all browsers (IE dropped)
  • Latest Chrome OS, Chrome

Issues to Verify

These issues should have either use the labels "status:ready-for-qa" or "status:ready-for-review." If it is ready for
QA then close the issue if fixed. If ready for review then leave open and assign back to the developer.

Link(s)


Accessibility (a11y) Dev Test

What to Test

  • Specific instructions can be found below.
  • Make sure the a11y feature testing doesn't negatively affect the sim in any way.
  • Load the a11y view and make sure that interacting with all elements in the simulation updates the appropriate
    descriptions in the PDOM.

Focus and Special Instructions

[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested,
list them here. Any behaviors you want QA to pay special attention to should be listed here.]

Link(s)

Screen Readers

This sim supports screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to screen
readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of
the information you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view
before opening the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as
intended.

Platforms and Screen Readers to Be Tested

  • Windows 10 + Latest Chrome + Latest JAWS
  • Windows 10 + Latest Firefox + Latest NVDA
  • macOS + Safari + VoiceOver
  • iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information

We are tracking known screen reader bugs in
this Google Document. If you find a
screen reader bug, please check it against this list.

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.

Magnification

This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel controls. Please test magnfication and make sure
it is working as intended and well with the use cases of the simulation. Due to the way screen readers handle user input, magnification is NOT expected to
work while using a screen reader so there is no need to test this case.


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@zepumph zepumph added QA:a11y QA:dev-test Dev test before an RC labels Dec 5, 2020
@ariel-phet ariel-phet removed their assignment Dec 7, 2020
@zepumph
Copy link
Member Author

zepumph commented Dec 7, 2020

There have already been a few minor bug fixes in the repo, please let me know when you are going to start testing this, and I will get a new dev version for you.

@zepumph zepumph changed the title Dev test: Ratio and Proportion 1.0.0-dev.75 Dev test: Ratio and Proportion 1.0.0-dev.XX Dec 7, 2020
@zepumph zepumph changed the title Dev test: Ratio and Proportion 1.0.0-dev.XX Dev test: Ratio and Proportion 1.0.0-dev.76 Dec 7, 2020
@zepumph
Copy link
Member Author

zepumph commented Dec 7, 2020

I updated to dev.76

@zepumph zepumph changed the title Dev test: Ratio and Proportion 1.0.0-dev.76 Dev test: Ratio and Proportion 1.0.0-dev.77 Dec 8, 2020
@zepumph
Copy link
Member Author

zepumph commented Dec 8, 2020

After another few bug fixes and half of a code review in phetsims/ratio-and-proportion#210, I updated the version to dev.77

I talked to @KatieWoe to make sure that she hadn't started testing yet.

@KatieWoe
Copy link
Contributor

KatieWoe commented Dec 8, 2020

  • Win 10 Chrome
  • Win 10 Firefox
  • Mac 11 Safari
  • iPadOS 14 Safari
  • ChromeOS

@zepumph
Copy link
Member Author

zepumph commented Dec 10, 2020

@KatieWoe, I didn't say this explicitly (just via the sections I left in the template above). This sim supports the following a11y features that should be thoroughly tested:

  • Full description with screen reader support
  • Alternative input
  • Sound/sonification
  • Mobile description with iOS + VO support
  • Zoom and Magnification

@KatieWoe
Copy link
Contributor

KatieWoe commented Dec 11, 2020

Adding Screen Reader Checkmarks:

  • Win 10 Chrome JAWS
  • Win 10 Firefox NVDA
  • MacOS 11 Safari VO
  • iPadOS Safari VO

@zepumph
Copy link
Member Author

zepumph commented Dec 11, 2020

@terracoda has been having a ton of trouble on mobile + VO on iOS 14. So it may be good to note potential trouble here. Though I don't know if there is an issue for this.

@KatieWoe
Copy link
Contributor

@zepumph I'll keep an eye out. I noticed she heard something about it saying "sky" and I think I saw something like that during #581, but screen reader testing was cut short there so I didn't make an issue at the time.

@zepumph
Copy link
Member Author

zepumph commented Dec 12, 2020

Ahh! That is great consistency to note (because of phetsims/ratio-and-proportion#256).

phetsims/scenery#1094 is the general blocking issue about a11y and iOS 14

@terracoda
Copy link
Contributor

In #582 (comment) @zepumph said:

@terracoda has been having a ton of trouble on mobile + VO on iOS 14. So it may be good to note potential trouble here. Though I don't know if there is an issue for this.

My understanding was that there is a general issue for this that was opened with iOS 14 was launched. Issue phetsims/ratio-and-proportion#256 seems to be specific to iOS 14, but phetsims/ratio-and-proportion#283 is happening on iOS 13.

I think the general issue about iOS 14 is that context responses no longer fire when using iOS 14. I am not sure if any progress has been made on that general issue.

@zepumph
Copy link
Member Author

zepumph commented Dec 15, 2020

My understanding was that there is a general issue for this that was opened. . .

See phetsims/scenery#1094

@KatieWoe
Copy link
Contributor

QA is done for the most part. I know @muedli is going to take one last look at Mac VO tonight, so I'll leave it to him to reassign and remove the tag.

@KatieWoe KatieWoe assigned zepumph and unassigned KatieWoe Dec 18, 2020
@zepumph
Copy link
Member Author

zepumph commented Feb 1, 2021

RC is is over in #601. So I'm going to close this. @muedli any testing you would like to do would be great over there :)

Thanks QA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:a11y QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

4 participants