Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check appearance of fonts in different locales #1036

Closed
jonathanolson opened this issue Feb 7, 2024 · 12 comments
Closed

Check appearance of fonts in different locales #1036

jonathanolson opened this issue Feb 7, 2024 · 12 comments
Assignees
@kathy-phet @KatieWoe

Comments

@jonathanolson
Copy link
Contributor

I committed a change onto main in https://github.com/phetsims/website-meteor/issues/656 that adjusts the fallback fonts to work around a Safari SVG issue (noticed for locales bn/th/hi).

I'd really appreciate testing if we can try across browsers/locales (however seems appropriate) to make sure that this change:

(a) doesn't degrade font/text appearance for any translated locale/browser combos
(b) doesn't miss any locales where the effects of https://github.com/phetsims/website-meteor/issues/656 are seen in Safari (or... other browsers).

I don't exactly know what testing to recommend, but at a minimum:

  • Test English on supported platforms (or possibly one or two other popular locales).
  • Test all locales on one or two Safari/macOS versions (newer supported, older supported) - maybe a spot-check on iPad

@KatieWoe thoughts?

I'd like to do a maintenance patch (or... include this in the other maintenance) if it works out fine.
@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 7, 2024

I think this sounds alright. I think the non-English locales should be tested on other platforms for at least one sim. Would you want this tested on main, or in the maintenance release?

@jonathanolson
Copy link
Contributor Author

On main would be great!

@jonathanolson jonathanolson removed their assignment Feb 7, 2024
@jonathanolson
Copy link
Contributor Author

Assorted links for testing (generated with perennial node js/scripts/locale-sim-list.js --limit=5 --production --phettest)

af (Afrikaans)

ak (Akan)

am (Amharic)

ar (Arabic)

ar_MA (Arabic, Morocco)

ar_SA (Arabic, Saudi Arabia)

ay (Aymara)

az (Azerbaijani)

be (Belarusian)

bg (Bulgarian)

bi (Bislama)

bn (Bengali)

bo (Tibetan)

bs (Bosnian)

ca (Catalan)

cs (Czech)

cy (Welsh)

da (Danish)

de (German)

ee (Ewe)

el (Greek)

en (English)

en_CA (English, Canada)

es (Spanish)

es_CO (Spanish, Colombia)

es_ES (Spanish, Spain)

es_MX (Spanish, Mexico)

es_PE (Spanish, Peru)

et (Estonian)

eu (Basque)

fa (Persian)

fi (Finnish)

fo (Faroese)

fr (French)

ga (Irish)

gl (Galician)

gu (Gujarati)

ha (Hausa)

hi (Hindi)

hr (Croatian)

ht (Haitian)

hu (Hungarian)

hy (Armenian)

ig (Igbo)

in (Indonesian)

is (Icelandic)

it (Italian)

iw (Hebrew)

ja (Japanese)

ka (Georgian)

ki (Kikuyu)

kk (Kazakh)

km (Khmer)

kn (Kannada)

ko (Korean)

ku (Kurdish)

ku_TR (Kurdish, Turkey)

lg (Ganda)

lo (Lao)

lt (Lithuanian)

lv (Latvian)

mg (Malagasy)

mi (Maori)

mk (Macedonian)

ml (Malayalam)

mn (Mongolian)

mo (Moldavian)

mr (Marathi)

ms (Malay)

mt (Maltese)

my (Burmese)

nb (Norwegian Bokmal)

ne (Nepali)

nl (Dutch)

nn (Norwegian Nynorsk)

ny (Chichewa)

om (Oromo)

or (Oriya)

pl (Polish)

ps (Pashto)

pt (Portuguese)

pt_BR (Portuguese, Brazil)

qu (Quechua)

ro (Romanian)

ru (Russian)

rw (Kinyarwanda)

sd (Sindhi)

se (Northern Sami)

sh (Serbo-Croatian)

si (Sinhalese)

sk (Slovak)

sl (Slovenian)

sn (Shona)

sq (Albanian)

sr (Serbian)

st (Sotho)

sv (Swedish)

sw (Swahili)

ta (Tamil)

te (Telugu)

tg (Tajik)

th (Thai)

ti (Tigrinya)

tk (Turkmen)

tl (Tagalog)

tn (Tswana)

tr (Turkish)

tw (Twi)

uk (Ukrainian)

ur (Urdu)

uz (Uzbek)

vi (Vietnamese)

wo (Wolof)

xh (Xhosa)

yo (Yoruba)

zh_CN (Chinese, Simplified)

zh_HK (Chinese, Hong Kong)

zh_TW (Chinese, Traditional)

zu (Zulu)

jonathanolson added a commit to phetsims/perennial that referenced this issue Feb 8, 2024
@jonathanolson
Adding locale-sim-list, see phetsims/qa#1036
aa27ac6
@jonathanolson
Copy link
Contributor Author

jonathanolson commented Feb 8, 2024 •
edited
Loading

Saw a good number of broken bits

I'll look into another patch to see if I can find a good backup font.

@jonathanolson
Copy link
Contributor Author

Also I'm noticing that in some sims it is much more likely to show issues (acid-base-solutions, balloons-and-static-electricity, etc.)

@kathy-phet
Copy link

@jonathanolson - This is just on Safari, correct?

@jonathanolson
Copy link
Contributor Author

Just Safari. I'll hopefully have improved testing in just a bit.

@jonathanolson
Copy link
Contributor Author

My latest workaround now just affects Safari, and will be most likely to affect appearance in:

  • Locales that were previously broken (locales are 'bn', 'bo', 'gu', 'hi', 'km', 'kn', 'ml', 'mr', 'or', 'si', 'ta', 'te', 'th')
  • Locales that have RTL translations (since the embedding marks are affected).

Sometime it would be good to talk through a testing strategy. Here's a fairly exhaustive list of what could be affected, perhaps some spot checks are worth it. (Now, the only thing that changes is if Safari is being run, so we'd only need to test Safari).

Perhaps some spot-checks that (a) this fixes the affected locales noted above, and (b) doesn't break RTL sims?

@Nancy-Salpepi
Copy link
Contributor

I did spot checks on the following sims on main by adding locales=* to the end of the url:
Acid-Base Solutions, Area Model Multiplication, Build a Nucleus, Center and Variability, Number Line: Distance and a bit on Balloons and Static Electricity. I also checked the About dialog in the PhET Menu, tabs in Preferences and the Keyboard dialog.

  • The broken locales now look great!

  • I didn't see any missing text

  • rtl languages (ar_Sa, ar_MA and iw) all looked fine to me

  • after playing around with a sim a bit and changing languages, some artifacts popped up, but for the most part I saw them in published as well.

@Nancy-Salpepi
Copy link
Contributor

@jonathanolson let QA know if there is anything else that needs to be done at this point or any other sims you think would be good to test.

@jonathanolson
Copy link
Contributor Author

Thanks, that sounds great!

@jonathanolson jonathanolson mentioned this issue Feb 12, 2024
Closed
@Nancy-Salpepi
Copy link
Contributor

Nancy-Salpepi commented Feb 15, 2024 •
edited
Loading

Adding comment to different issue. Closing this again.

@Nancy-Salpepi Nancy-Salpepi reopened this Feb 15, 2024
@jonathanolson jonathanolson mentioned this issue Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kathy-phet kathy-phet

@KatieWoe KatieWoe

Labels
None yet
Projects
QA Pipeline
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonathanolson @kathy-phet @KatieWoe @Nancy-Salpepi