Skip to content

Commit

Permalink
add items for Property sub-classes and validation options, see phetsi…
Browse files Browse the repository at this point in the history
  • Loading branch information
mbarlow12 committed Sep 30, 2018
1 parent 857b974 commit 117c5d4
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions checklists/code_review_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,10 @@ var thoughts = happy ? ‘I am happy’ : ‘I am not happy :(’;
- [ ] Naming for Property values: All `AXON/Property` instances should be declared with the suffix `Property`. For example, if a visible property is added, it should have the name `visibleProperty` instead of simply `visible`. This will help to avoid confusion with non-Property definitions.
- [ ] Properties should use type-specific subclasses where appropriate (.e.g BooleanProperty, NumberProperty, StringProperty) or provide documentation as to why they are not.
- [ ] Are Property value validation options (`valueType`, `validValues`, etc...) utilized? Is their presence or lack thereof properly documented?
- [ ] Line comments should generally be preceded by a blank line. For example:
```js
Expand Down

0 comments on commit 117c5d4

Please sign in to comment.