Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Item" suffix to Solute combo box items #195

Closed
7 tasks done
pixelzoom opened this issue Aug 13, 2020 · 6 comments
Closed
7 tasks done

Add "Item" suffix to Solute combo box items #195

pixelzoom opened this issue Aug 13, 2020 · 6 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Aug 13, 2020

Over in phetsims/sun#615, it was decided that elements in a group should still have a tandem name that indicates their type.

In pH Scale, the combo box items under soluteComboBox.listBox should all have an "Item" suffix. Doing this by concatenating "Item" onto the solute tandemName is OK.

TODO list:

  • add "Item" suffix in SoluteComboBox.js
  • update any ids that appear in overrides.js
  • update ph-scale client guides
  • update ph-scale-basics client guides
  • cherry pick to ph-scale 1.4
  • cherry-pick to ph-scale-basics 1.4
  • cherry-pick common-code changes that enforce "Item" suffix
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Aug 13, 2020

@arouinfar please review the changes to the client guides for ph-scale and ph-scale-basics. They have been pushed to master, ph-scale 1.4, and ph-scale-basics 1.4. If they look OK, you can unassign yourself and reassigned to me. Thanks.

@pixelzoom
Copy link
Contributor Author

ComboBoxItem change is phetsims/sun@187ac98 and has been cherry-picked to ph-scale 1.4 and ph-scale-basics 1.4.

pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Aug 13, 2020
@pixelzoom
Copy link
Contributor Author

Cherry-picked phetsims/sun@55c4fc0, which improves the error message for the assertion in ComboBoxItem.

@arouinfar
Copy link
Contributor

@pixelzoom the changes are all looking good in master. I reviewed the tree, client guides, and checked that relevant elements remained phetioFeatured.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Aug 15, 2020

Ready for testing in next RC. To verify:

  1. Run the sim in Studio
  2. Verify that all of the combo box items under phScale.macroScreen.view.soluteComboBox.listBox have a name that ends with "Item". E.g. "batteryAcidItem".
  3. (ph-scale only) Verify that all of the combo box items under phScale.microScreen.view.soluteComboBox.listBox have a name that ends with "Item". E.g. "batteryAcidItem".

@KatieWoe
Copy link
Contributor

Win 10 Chrome 1.5.0-dev.1 #195 (comment) looks ok. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants