Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X button on dialog may have too small pointer area #194

Closed
pixelzoom opened this issue Aug 10, 2020 · 5 comments
Closed

X button on dialog may have too small pointer area #194

pixelzoom opened this issue Aug 10, 2020 · 5 comments
Assignees
@KatieWoe

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Aug 10, 2020 •
edited
Loading

Fix to be applied from phetsims/sun#610.

See phetsims/sun#610 (comment)
@pixelzoom pixelzoom self-assigned this Aug 10, 2020
pixelzoom added a commit to phetsims/sun that referenced this issue Aug 10, 2020
@pixelzoom
patch for Dialog close button in release branch, #610, phetsims/ph-sc…
8182ba7 
…ale#194
pixelzoom added a commit that referenced this issue Aug 10, 2020
@pixelzoom
https://github.com/phetsims/ph-scale/issues/194
bc85162
pixelzoom added a commit to phetsims/sun that referenced this issue Aug 10, 2020
@pixelzoom
patch for Dialog close button in release branch, #610, phetsims/ph-sc…
4e4fc6f 
…ale#194
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Aug 10, 2020
@pixelzoom
https://github.com/phetsims/ph-scale/issues/194
bb984d4
@pixelzoom pixelzoom mentioned this issue Aug 10, 2020
Closed
@pixelzoom
Copy link
Contributor Author

phetsims/sun#610 (comment) recommended cherry-picking phetsims/sun@9c9f263. I ran into big merge conflicts. Since phetsims/sun@9c9f263 only modified 2 lines of code, I ended up applying the changes manually.

Ready for testing in next RC.

@pixelzoom pixelzoom removed their assignment Aug 10, 2020
This was referenced Aug 10, 2020
Closed
Closed
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Aug 10, 2020 •
edited
Loading

To verify in the next RC:

Open the About dialog and inspect the size of its 'X' close button.

This was referenced Aug 17, 2020
Closed
Closed
@pixelzoom pixelzoom mentioned this issue May 12, 2021
Closed
19 tasks
@brooklynlash
Copy link

Touch area and mouse area are a good size on Chromebook.

@pixelzoom
Copy link
Contributor Author

Thanks @brooklynlash.

@KatieWoe are you planning to test on other platforms, or can this be closed?

@KatieWoe
Copy link
Contributor

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KatieWoe KatieWoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @KatieWoe @brooklynlash