Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update credits for 1.5.0 release #155

Closed
Tracked by #677 ...
pixelzoom opened this issue Mar 30, 2020 · 15 comments
Closed
Tracked by #677 ...

update credits for 1.5.0 release #155

pixelzoom opened this issue Mar 30, 2020 · 15 comments

Comments

@pixelzoom
Copy link
Contributor

Current credits are shown below. @arouinfar @KatieWoe please let me know what you'd like to change.

screenshot_232

@arouinfar
Copy link
Contributor

arouinfar commented Mar 30, 2020

The convention for design credits has been to include the legacy lead/team.

@pixelzoom please...

  • Add Archie Paulson to lead design
  • Add Wendy Adams, Jack Barbera, and Laurie Langdon to the team

While ph-scale-basics does not have a Java version, it is essentially the first screen of ph-scale, so I think it's appropriate to credit the legacy team there as well. I suspect the credits are already shared between the two sims (as was done in the Gas Props suite), but I wanted to be clear that I understand these changes will affect both sims.

@arouinfar arouinfar assigned pixelzoom and unassigned arouinfar Mar 30, 2020
@pixelzoom
Copy link
Contributor Author

@arouinfar Yes, the same credits are shared by ph-scale and ph-scale-basics.

pixelzoom added a commit that referenced this issue Mar 31, 2020
@pixelzoom
Copy link
Contributor Author

@arouinfar FYI, here are the revised credits:

screenshot_233

@pixelzoom pixelzoom removed their assignment Mar 31, 2020
@KatieWoe
Copy link
Contributor

So far Logan Bray and Jacob Romero should be added to QA

pixelzoom added a commit that referenced this issue Mar 31, 2020
@pixelzoom
Copy link
Contributor Author

Updated QA credits are shown below. @KatieWoe I'll leave this assigned to you until the QA process is finished, in case we need to add additional names.

screenshot_234

@pixelzoom
Copy link
Contributor Author

@KatieWoe now that 1.4.0-rc.1 testing is completed, please indicate who you would like to add to the QA credits.

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 4, 2020

Sorry about that. Everyone looks accounted for in #155 (comment)

@pixelzoom
Copy link
Contributor Author

1.4 release branches have been abandoned, and the RC process will be restarted with a new release branch. See #166 (comment).

Changing the title of this issue for 1.5 release.

@pixelzoom pixelzoom changed the title update credits for 1.4.0 release update credits for 1.5.0 release Aug 26, 2020
@stemilymill
Copy link

Found during phetsims/qa#669

My name is in the Team section instead of the QA section, and I think Brooklyn Lash and Clifford Hardin need to be added to QA as well @KatieWoe

name in wrong section of credits

@KatieWoe
Copy link
Contributor

Good catch

pixelzoom added a commit that referenced this issue Jul 15, 2021
pixelzoom added a commit that referenced this issue Jul 15, 2021
pixelzoom added a commit that referenced this issue Jul 15, 2021
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jul 15, 2021
@pixelzoom
Copy link
Contributor Author

QA credits updated, patched in 1.5 branches for ph-scale and ph-scale-basics. Example screenshot below, from master. Ready for verification in next RC.

screenshot_1063

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 19, 2021

Looks like I need to add @Nancy-Salpepi "Nancy Salpepi" to the QA credits in master and 1.5 branches (ph-scale and ph-scale-basics). Self assigning.

@stemilymill
Copy link

@pixelzoom @KatieWoe Devon Quispe has also worked on pH. I don't know if anyone else is missing

pixelzoom added a commit that referenced this issue Jul 20, 2021
pixelzoom added a commit that referenced this issue Jul 20, 2021
pixelzoom added a commit that referenced this issue Jul 20, 2021
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jul 20, 2021
@pixelzoom
Copy link
Contributor Author

Updated QA credits are shown below, added Nancy Salpepi and Devon Quispe in master and 1.5 branches. Ready for verification in next RC.

screenshot_1074

@KatieWoe
Copy link
Contributor

This looks ok in rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants