update missing repo scripts to take file arg, add two data files #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this PR, I am indicating to the PhET maintainers that I have read and understood
the contributing guidelines and that this PR follows those guidelines to the best of my knowledge.
I also understand that my PR can't be merged until I have singed the contributor license agreement.
<Please provide a high-level description of your PR.>
Expanded
clone-missing-repos.shto take a file argument from perennial/data. The intention is to enable an easy way to provide instructions to set up a simulation development environment without pulling every one of the PhET repos, which is what the phet development overview and current structure of clone-missing-repos.sh (hard codes perennial/data/active-repos). Updatedprint-missing-repos.shto take the same argument and to accept it fromclone-missing-repos.sh.I tested with the additional
example-simandscenerystack-alldata files I added.I don't think this has any downstream effects or affects typical usage (default remains
active-reposwith no arg provided. Do let me know if that seems incorrect or there is a better way to implement.