Introduced parentheses for ternary expressions for #42

phetsims · Jul 18, 2021 · b7035a0 · b7035a0
1 parent 00bb665
commit b7035a0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/js/common/view/DistanceShadedNumberLineNode.js b/js/common/view/DistanceShadedNumberLineNode.js
@@ -93,7 +93,7 @@ class DistanceShadedNumberLineNode extends SpatializedNumberLineNode {
 
         // Get which strings to use for point names based on the number line orientation.
         // The strings are ordered based on isPrimaryNodeSwapped.
-        const labelStrings = orientation === Orientation.VERTICAL ?
+        const labelStrings = ( orientation === Orientation.VERTICAL ) ?
           [ NLDConstants.Y_1_STRING, NLDConstants.Y_2_STRING ] : [ NLDConstants.X_1_STRING, NLDConstants.X_2_STRING ];
         if ( isPrimaryNodeSwapped ) {
           const temp = labelStrings[ 0 ];
@@ -138,7 +138,7 @@ class DistanceShadedNumberLineNode extends SpatializedNumberLineNode {
         // on each end. The endpoint positions are needed in case a point is off the scale of the number line and the
         // shading needs to go all the way to the end of the number line.
         const insetSize = this.options.displayedRangeInset - this.options.arrowSize;
-        const insetVector = model.numberLine.orientationProperty.value === Orientation.HORIZONTAL ?
+        const insetVector = ( model.numberLine.orientationProperty.value === Orientation.HORIZONTAL ) ?
                             new Vector2( insetSize, 0 ) :
                             new Vector2( 0, -insetSize );
         const endPointPositionMin = model.numberLine.valueToModelPosition( displayedRange.min ).minus( insetVector );

diff --git a/js/generic/model/NLDGenericModel.js b/js/generic/model/NLDGenericModel.js
@@ -53,7 +53,7 @@ class NLDGenericModel extends AbstractNLDBaseModel {
 
     // change box bounds when number line orientation changes
     this.numberLine.orientationProperty.link( orientation => {
-      this.pointControllerBoxProperty.value = orientation === Orientation.HORIZONTAL ?
+      this.pointControllerBoxProperty.value = ( orientation === Orientation.HORIZONTAL ) ?
                                               NLDConstants.BOTTOM_BOX_BOUNDS :
                                               NLDConstants.SIDE_BOX_BOUNDS;
     } );