Skip to content

Commit

Permalink
fix Tandem.OPT_OUT for timeInPercentProperty
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Sep 15, 2020
1 parent 1061d99 commit e9aa18f
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions js/common/model/GenerationClock.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,7 @@ class GenerationClock extends PhetioObject {
this.timeInPercentProperty = new DerivedProperty(
[ this.timeInSecondsProperty ],
timeInSeconds => ( timeInSeconds % SECONDS_PER_GENERATION ) / SECONDS_PER_GENERATION, {
isValidValue: timeInPercent => ( timeInPercent >= 0 && timeInPercent <= 1 )
}, {
//REVIEW: This tandem opt-out should presumably be in the options object above with isValidValue?
isValidValue: timeInPercent => ( timeInPercent >= 0 && timeInPercent <= 1 ),
tandem: Tandem.OPT_OUT
} );

Expand Down

1 comment on commit e9aa18f

@pixelzoom
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.