Skip to content

Commit

Permalink
remove @param translated from Genotype toAbbreviation, #203
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Sep 15, 2020
1 parent c525fe3 commit c7f58c5
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions js/common/model/Genotype.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,17 +142,15 @@ class Genotype extends PhetioObject {
}

/**
* Converts a Genotype to its abbreviation, e.g. 'FfEEtt'.
* Converts a Genotype to its untranslated abbreviation, e.g. 'FfEEtt'.
* This is intended for debugging only. Do not rely on the format!
* @param {boolean} translated - true = translated (default), false = not translated
* @returns {string}
* REVIEW: Curious about why we're handling untranslated abbreviations, is it for phet-io? I never see this called with an option here
* @public
*/
toAbbreviation( translated = true ) {
return this.furGenePair.getGenotypeAbbreviation( translated ) +
this.earsGenePair.getGenotypeAbbreviation( translated ) +
this.teethGenePair.getGenotypeAbbreviation( translated );
toAbbreviation() {
return this.furGenePair.getGenotypeAbbreviation( false ) +
this.earsGenePair.getGenotypeAbbreviation( false ) +
this.teethGenePair.getGenotypeAbbreviation( false );
}

/**
Expand Down

0 comments on commit c7f58c5

Please sign in to comment.