Doc fix and memory leak fix, see #203

phetsims · Sep 15, 2020 · b74af3f · b74af3f
1 parent bd3532a
commit b74af3f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/js/common/model/BunnyCollection.js b/js/common/model/BunnyCollection.js
@@ -74,7 +74,7 @@ class BunnyCollection {
       tandem: options.tandem.createTandem( 'deadBunnies' )
     } );
 
-    // @private {Bunny[]} Recessive mutants, to be mated eagerly so that their mutation appears in the phenotype as
+    // @private {BunnyArray} Recessive mutants, to be mated eagerly so that their mutation appears in the phenotype as
     // soon as possible. Mutants are added to this array when born, and removed as soon as they have mated with
     // another bunny that has the same mutant allele. See also the 'Recessive Mutants' section of model.md at
     // https://github.com/phetsims/natural-selection/blob/master/doc/model.md#recessive-mutants.

diff --git a/js/common/view/pedigree/PedigreeBunnyNode.js b/js/common/view/pedigree/PedigreeBunnyNode.js
@@ -125,6 +125,9 @@ class PedigreeBunnyNode extends Node {
       if ( bunny.diedEmitter.hasListener( addRedCrossMark ) ) {
         bunny.diedEmitter.removeListener( addRedCrossMark );
       }
+
+      // Un-parent the bunnyNode from the shared DAG
+      bunnyNode.dispose();
     };
 
     // If logging is enabled, pressing on a bunny logs its details to the console.