Skip to content

Commit

Permalink
REVIEW comments, see #203
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanolson committed Sep 16, 2020
1 parent efc8945 commit b4a0d5b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions js/common/view/GenesVisibilityManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ class GenesVisibilityManager {
pedigreeNode.setGeneVisible( gene, visible );
} );

//REVIEW: Used to use the returned Property?
return property;
}

Expand Down
1 change: 1 addition & 0 deletions js/common/view/NaturalSelectionScreenView.js
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ class NaturalSelectionScreenView extends ScreenView {

// Simulation mode determines which UI controls are enabled. unlink is not necessary.
model.simulationModeProperty.link( simulationMode => {
//REVIEW: Is the commonality not factored out for a reason?
if ( simulationMode === SimulationMode.STAGED ) {
addMutationsPanel.setContentEnabled( true );
environmentalFactorsPanel.setContentEnabled( true );
Expand Down

0 comments on commit b4a0d5b

Please sign in to comment.