Skip to content

Commit

Permalink
use ts-expect-error instead of ts-ignore, phetsims/chipper#1363
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Dec 7, 2022
1 parent 9a19cdc commit a9f048c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions js/realmolecules/view/JSmolViewerNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const RESULT_TRUE = 'true';
const RESULT_FALSE = 'false';

// Jmol is loaded via <script> in the .html file, this prevents lint from complaining the Jmol is undefined.
// @ts-ignore https://github.com/phetsims/molecule-polarity/issues/15
// @ts-expect-error https://github.com/phetsims/molecule-polarity/issues/15
const Jmol = window.Jmol;

// each Jmol object instance is given a new identifier, numbered sequentially
Expand Down Expand Up @@ -226,7 +226,7 @@ export default class JSmolViewerNode extends DOM {
const appletId = `jmolApplet${instanceNumber++}`; // create a unique id for this viewer
Jmol.getApplet( appletId, appletConfig ); // creates window[appletId]

// @ts-ignore https://github.com/phetsims/molecule-polarity/issues/15
// @ts-expect-error https://github.com/phetsims/molecule-polarity/issues/15
this.applet = window[ appletId ]; // so that we don't pollute our code with window[appletId]
this.div.innerHTML = Jmol.getAppletHtml( this.applet ); // add the viewer's HTML fragment to this node's HTML element
this.applet._cover( false ); // TODO Why do we need to call this? See https://github.com/phetsims/molecule-polarity/issues/14
Expand Down

0 comments on commit a9f048c

Please sign in to comment.