Skip to content

Commit

Permalink
lint fixes for visibility annotations, phetsims/chipper#932
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed May 8, 2020
1 parent 110f0b0 commit 1476951
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 4 deletions.
4 changes: 1 addition & 3 deletions js/common/view/PlateNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ class PlateNode extends Node {
* Creates a positive plate.
* @param {EField} eField
* @returns {PlateNode}
* @static
* @public
*/
static createPositive( eField ) {
Expand All @@ -109,8 +108,7 @@ class PlateNode extends Node {
* Creates a negative plate.
* @param {EField} eField
* @returns {PlateNode}
* @static
* @static
* @public
*/
static createNegative( eField ) {
return new PlateNode( eField, {
Expand Down
3 changes: 2 additions & 1 deletion js/realmolecules/view/JSmolViewerNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,12 @@ class JSmolViewerNode extends DOM {
this.elementsProperty = new Property( null );
}

// @public
isInitialized() {
return ( this.applet !== null );
}

// Call this after the sim has started running
// @public Call this after the sim has started running
initialize() {

assert && assert( !this.isInitialized(), 'already initialized' );
Expand Down
20 changes: 20 additions & 0 deletions js/realmolecules/view/RealMoleculeViewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,22 +114,42 @@ class RealMoleculeViewer extends Node {
} );
}

/**
* @param {boolean} visible
* @public
*/
setBondDipolesVisible( visible ) {
this.bondDipolesText.fill = visible ? 'black' : 'gray';
}

/**
* @param {boolean} visible
* @public
*/
setMolecularDipoleVisible( visible ) {
this.molecularDipoleText.fill = visible ? 'black' : 'gray';
}

/**
* @param {boolean} visible
* @public
*/
setPartialChargesVisible( visible ) {
this.partialChargesText.fill = visible ? 'black' : 'gray';
}

/**
* @param {boolean} visible
* @public
*/
setAtomLabelsVisible( visible ) {
this.atomLabelsText.fill = visible ? 'black' : 'gray';
}

/**
* @param {SurfaceType} surfaceType
* @public
*/
setSurfaceType( surfaceType ) {
this.surfaceTypeText.text = ( 'surface: ' + surfaceType.name );
}
Expand Down

0 comments on commit 1476951

Please sign in to comment.