Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of excludeInvisibleChildrenFromBounds: false #292

Closed
jessegreenberg opened this issue Jun 14, 2024 · 2 comments
Closed

Usage of excludeInvisibleChildrenFromBounds: false #292

jessegreenberg opened this issue Jun 14, 2024 · 2 comments
Assignees
@jessegreenberg
Labels
dev:code-review status:ready-for-review

Comments

@jessegreenberg
Copy link
Contributor

There are a few places where I see excludeInvisibleChildrenFromBounds: false. Can these be removed, or can you document why they are necessary?

For #270.
marlitas added a commit that referenced this issue Jun 25, 2024
@marlitas
Remove unnecessary excludeInvisibleChildrenFromBounds, see: #292
ce6489e
@marlitas
Copy link
Contributor

A couple were not necessary. I left documentation for the one used in an HBox. @jessegreenberg can you review and let me know if any more documentation would be helpful.

@marlitas marlitas assigned jessegreenberg and unassigned marlitas Jun 25, 2024
@jessegreenberg
Copy link
Contributor Author

Great, thanks. And that will be helpful documentation in MeanPredictionFulcrumSlider. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
dev:code-review status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @marlitas