Skip to content

Commit

Permalink
minor formatting changes and variable name changes, see #270
Browse files Browse the repository at this point in the history
  • Loading branch information
jessegreenberg committed Jun 18, 2024
1 parent 06dd2b8 commit d7029ba
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions js/level-out/view/LevelOutScreenView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,13 @@ export default class LevelOutScreenView extends MeanShareAndBalanceScreenView {
centerX: this.playAreaCenterX
} );

const meanPredictSliderMVT = ModelViewTransform2.createSinglePointScaleInvertedYMapping( new Vector2( 0, 0 ),
const meanPredictSliderModelViewTransform = ModelViewTransform2.createSinglePointScaleInvertedYMapping( new Vector2( 0, 0 ),
new Vector2( this.playAreaCenterX, MeanShareAndBalanceConstants.NOTEPAD_CUPS_BOTTOM_Y ), MeanShareAndBalanceConstants.CUP_HEIGHT );
const meanPredictionSlider = new MeanPredictionSlider(
model.meanPredictionProperty,
model.dragRange,
createSuccessIndicatorMultilink,
meanPredictSliderMVT,
meanPredictSliderModelViewTransform,
{
visibleProperty: model.predictMeanVisibleProperty,
valueProperty: model.meanPredictionProperty,
Expand Down
1 change: 0 additions & 1 deletion js/level-out/view/PipeSwitch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* VBox that contains the AB Switch that toggles between pipe Open/Closed states
*
* @author Marla Schulz (PhET Interactive Simulations)
*
*/

import meanShareAndBalance from '../../meanShareAndBalance.js';
Expand Down
6 changes: 3 additions & 3 deletions js/level-out/view/TableCupNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ export default class TableCupNode extends Node {

public constructor( tickMarksVisibleProperty: Property<boolean>,
model: Pick<LevelOutModel, 'changeWaterLevel'>,
waterCup: Cup, notepadMVT: ModelViewTransform2,
waterCup: Cup, notepadModelViewTransform: ModelViewTransform2,
providedOptions?: TableCupNodeOptions ) {

const options = optionize<TableCupNodeOptions, SelfOptions, NodeOptions>()( {
bottom: notepadMVT.modelToViewY( 0 ),
bottom: notepadModelViewTransform.modelToViewY( 0 ),
visibleProperty: waterCup.isActiveProperty,
soundPlayerCrossFade: 0,
isDisposable: false
Expand Down Expand Up @@ -85,7 +85,7 @@ export default class TableCupNode extends Node {

// Set position
waterCup.xPositionProperty.link( xPosition => {
this.left = notepadMVT.transformX( xPosition );
this.left = notepadModelViewTransform.transformX( xPosition );
} );
}
}
Expand Down

0 comments on commit d7029ba

Please sign in to comment.