-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to typescript handling of i18n dynamic strings #892
Comments
Ok. I had good success here. I like all of the changes, specifying |
zepumph
added a commit
to phetsims/brand
that referenced
this issue
Dec 12, 2022
zepumph
added a commit
to phetsims/number-play
that referenced
this issue
Dec 12, 2022
zepumph
added a commit
to phetsims/chipper
that referenced
this issue
Dec 12, 2022
zepumph
added a commit
that referenced
this issue
Dec 12, 2022
zepumph
added a commit
to phetsims/sound-waves
that referenced
this issue
Dec 12, 2022
samreid
added a commit
to phetsims/chipper
that referenced
this issue
Dec 16, 2022
I found some sims such as Molecule Shapes allow empty english strings, so I adjusted the assertion. Tagging @zepumph in case this is unexpected. |
jbphet
pushed a commit
that referenced
this issue
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on phetsims/chipper#1366, I found that most of the @ts-expect-errors in joist have to do with the newish dynamic locales, mapping a locale string to a general string and then trying to pull the string union back out. Luckily, in my working copy I'm finding it quite easy to base everything on the typeof the locale map object for exact type checking.
The text was updated successfully, but these errors were encountered: