Screen name must be a Property, clean up Screen.nameProperty implemen…

…tation, phetsims/joist#844
phetsims · Sep 16, 2022 · 7298be4 · 7298be4
1 parent 27e97bb
commit 7298be4
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/js/layer-model/LayerModelScreen.ts b/js/layer-model/LayerModelScreen.ts
@@ -24,7 +24,7 @@ class LayerModelScreen extends Screen<LayerModelModel, LayerModelScreenView> {
       homeScreenIcon: new RandomIcon( 544 ),
       maxDT: GreenhouseEffectConstants.MAX_DT,
       tandem: tandem,
-      name: GreenhouseEffectStrings.screen.layerModel,
+      name: GreenhouseEffectStrings.screen.layerModelStringProperty,
       keyboardHelpNode: new GreenhouseEffectKeyboardHelpContent()
     };
 

diff --git a/js/micro/MicroScreen.js b/js/micro/MicroScreen.js
@@ -24,7 +24,7 @@ class MicroScreen extends Screen {
       backgroundColorProperty: new Property( '#C5D6E8' ),
       homeScreenIcon: new RandomIcon( 549 ),
       tandem: tandem,
-      name: GreenhouseEffectStrings.screen.micro,
+      name: GreenhouseEffectStrings.screen.microStringProperty,
 
       // TODO: This should use the same content as molecules-and-light,
       // MoleculesAndLightKeyboardHelpContent should be moved to this repo.

diff --git a/js/photons/PhotonsScreen.ts b/js/photons/PhotonsScreen.ts
@@ -24,7 +24,7 @@ class PhotonsScreen extends Screen<PhotonsModel, PhotonsScreenView> {
       homeScreenIcon: new RandomIcon( 1 ),
       maxDT: GreenhouseEffectConstants.MAX_DT,
       tandem: tandem,
-      name: GreenhouseEffectStrings.screen.photons,
+      name: GreenhouseEffectStrings.screen.photonsStringProperty,
       descriptionContent: GreenhouseEffectStrings.a11y.photons.homeScreenDescription,
       keyboardHelpNode: new GreenhouseEffectKeyboardHelpContent()
     };

diff --git a/js/waves/WavesScreen.ts b/js/waves/WavesScreen.ts
@@ -24,7 +24,7 @@ class WavesScreen extends Screen<WavesModel, WavesScreenView> {
       homeScreenIcon: new RandomIcon( 552 ),
       maxDT: GreenhouseEffectConstants.MAX_DT,
       tandem: tandem,
-      name: GreenhouseEffectStrings.screen.waves,
+      name: GreenhouseEffectStrings.screen.wavesStringProperty,
       descriptionContent: GreenhouseEffectStrings.a11y.waves.homeScreenDescription,
       keyboardHelpNode: new GreenhouseEffectKeyboardHelpContent()
     };