Skip to content

Commit

Permalink
Add gravityAndOrbitsStrings.d.ts, see phetsims/chipper#1053
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Oct 12, 2021
1 parent c6c7cb4 commit 52e127c
Show file tree
Hide file tree
Showing 11 changed files with 6 additions and 28 deletions.
4 changes: 0 additions & 4 deletions js/common/model/Body.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,9 @@ import GravityAndOrbitsModel from './GravityAndOrbitsModel';
import Tandem from '../../../../tandem/js/Tandem.js';
import type {GravityAndOrbitsBodiesType} from './GravityAndOrbitsBodies';

// @ts-ignore
const moonString = gravityAndOrbitsStrings.moon;
// @ts-ignore
const planetString = gravityAndOrbitsStrings.planet;
// @ts-ignore
const satelliteString = gravityAndOrbitsStrings.satellite;
// @ts-ignore
const starString = gravityAndOrbitsStrings.star;

// reduce Vector2 allocation by reusing this Vector2 in collidesWith computation
Expand Down
6 changes: 0 additions & 6 deletions js/common/view/CheckboxPanel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,11 @@ import GravityAndOrbitsColors from '../GravityAndOrbitsColors.js';
import GravityAndOrbitsGridNode from './GravityAndOrbitsGridNode.js';
import GravityAndOrbitsModel from '../model/GravityAndOrbitsModel.js';

// @ts-ignore
const gravityForceString = gravityAndOrbitsStrings.gravityForce;
// @ts-ignore
const gridString = gravityAndOrbitsStrings.grid;
// @ts-ignore
const massString = gravityAndOrbitsStrings.mass;
// @ts-ignore
const measuringTapeString = gravityAndOrbitsStrings.measuringTape;
// @ts-ignore
const pathString = gravityAndOrbitsStrings.path;
// @ts-ignore
const velocityString = gravityAndOrbitsStrings.velocity;

// constants
Expand Down
3 changes: 0 additions & 3 deletions js/common/view/EarthMassReadoutNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,10 @@ import gravityAndOrbitsStrings from '../../gravityAndOrbitsStrings.js';
import GravityAndOrbitsConstants from '../GravityAndOrbitsConstants.js';
import MassReadoutNode from './MassReadoutNode.js';

// @ts-ignore
const earthMassesString = gravityAndOrbitsStrings.earthMasses;
// @ts-ignore
const earthMassString = gravityAndOrbitsStrings.earthMass;
// @ts-ignore
const pattern0Value1UnitsString = gravityAndOrbitsStrings.pattern[ '0value' ][ '1units' ];
// @ts-ignore
const thousandEarthMassesString = gravityAndOrbitsStrings.thousandEarthMasses;

class EarthMassReadoutNode extends MassReadoutNode {
Expand Down
2 changes: 0 additions & 2 deletions js/common/view/GravityAndOrbitsSceneView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ import GravityAndOrbitsModel from '../model/GravityAndOrbitsModel.js';
import Tandem from '../../../../tandem/js/Tandem.js';
import ModelViewTransform2 from '../../../../phetcommon/js/view/ModelViewTransform2';

// @ts-ignore
const returnObjectsString = gravityAndOrbitsStrings.returnObjects;
// @ts-ignore
const vString = gravityAndOrbitsStrings.v;

// constants
Expand Down
4 changes: 0 additions & 4 deletions js/common/view/GravityControl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,8 @@ import GravityAndOrbitsColors from '../GravityAndOrbitsColors.js';
import Property from '../../../../axon/js/Property';
import Tandem from '../../../../tandem/js/Tandem.js';

// @ts-ignore
const gravityString = gravityAndOrbitsStrings.gravity;

// @ts-ignore
const offString = gravityAndOrbitsStrings.off;
// @ts-ignore
const onString = gravityAndOrbitsStrings.on;

// constants
Expand Down
4 changes: 0 additions & 4 deletions js/common/view/MassControlPanel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,9 @@ import BodyMassControl from './BodyMassControl.js';
import Body from '../model/Body.js';
import Tandem from '../../../../tandem/js/Tandem.js';

// @ts-ignore
const moonMassString = gravityAndOrbitsStrings.moonMass;
// @ts-ignore
const planetMassString = gravityAndOrbitsStrings.planetMass;
// @ts-ignore
const satelliteMassString = gravityAndOrbitsStrings.satelliteMass;
// @ts-ignore
const starMassString = gravityAndOrbitsStrings.starMass;

// constants
Expand Down
3 changes: 1 addition & 2 deletions js/common/view/SpaceStationMassReadoutNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,10 @@ import GravityAndOrbitsConstants from '../GravityAndOrbitsConstants.js';
import BodyNode from './BodyNode.js';
import MassReadoutNode from './MassReadoutNode.js';

// @ts-ignore
const billionBillionSpaceStationMassesString = gravityAndOrbitsStrings.billionBillionSpaceStationMasses;

// @ts-ignore
const pattern0Value1UnitsString = gravityAndOrbitsStrings.pattern[ '0value' ][ '1units' ];
// @ts-ignore
const spaceStationMassString = gravityAndOrbitsStrings.spaceStationMass;

class SpaceStationMassReadoutNode extends MassReadoutNode {
Expand Down
1 change: 0 additions & 1 deletion js/common/view/TimeCounter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import gravityAndOrbitsStrings from '../../gravityAndOrbitsStrings.js';
import GravityAndOrbitsColors from '../GravityAndOrbitsColors.js';
import GravityAndOrbitsClock from '../model/GravityAndOrbitsClock.js';

// @ts-ignore
const clearString = gravityAndOrbitsStrings.clear;

// constants
Expand Down
5 changes: 5 additions & 0 deletions js/gravityAndOrbitsStrings.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// Copyright 2021, University of Colorado Boulder

type t = { [ key: string ]: string };
let gravityAndOrbitsStrings: t;
export default gravityAndOrbitsStrings;
1 change: 0 additions & 1 deletion js/model/ModelScreen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import ModelModel from './ModelModel.js';
import GravityAndOrbitsModel from '../common/model/GravityAndOrbitsModel.js';
import ProfileColorProperty from '../../../scenery/js/util/ProfileColorProperty';

// @ts-ignore
const modelString = gravityAndOrbitsStrings.model;

type ModelScreenOptions = {
Expand Down
1 change: 0 additions & 1 deletion js/toScale/ToScaleScreen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import GravityAndOrbitsModel from '../common/model/GravityAndOrbitsModel.js';
import Tandem from '../../../tandem/js/Tandem.js';
import ProfileColorProperty from '../../../scenery/js/util/ProfileColorProperty';

// @ts-ignore
const toScaleString = gravityAndOrbitsStrings.toScale;

type ScreenOptions = {
Expand Down

0 comments on commit 52e127c

Please sign in to comment.