Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update credits for 1.4 release #155

Closed
Tracked by #1066 ...
pixelzoom opened this issue Apr 9, 2024 · 16 comments
Closed
Tracked by #1066 ...

Update credits for 1.4 release #155

pixelzoom opened this issue Apr 9, 2024 · 16 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 9, 2024

For #142 ...

@KatieWoe please identify QA credit updates in this issue.

The current credits are:

screenshot_3212
@KatieWoe
Copy link
Contributor

So far Nancy Salpepi and Jaron Droder should be added.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 19, 2024

phetsims/qa#1066 and phetsims/qa#1067 RC1 tests have been completed. Before I deploy RC2... @KatieWoe is there anyone else I need to add other than Nancy Salpepi and Jaron Droder?

@KatieWoe
Copy link
Contributor

Nancy Salpepi, Clifford Hardin, and Jaron Droder should be added.

@pixelzoom pixelzoom self-assigned this Apr 19, 2024
@amanda-phet
Copy link
Contributor

Please add Mariah Hermsmeyer and Amanda McGarry to graphic arts.

pixelzoom added a commit to phetsims/graphing-slope-intercept that referenced this issue Apr 19, 2024
@amanda-phet
Copy link
Contributor

I don't see artwork from Megan Lai... is she in a license somewhere?

pixelzoom added a commit that referenced this issue Apr 19, 2024
pixelzoom added a commit that referenced this issue Apr 19, 2024
pixelzoom added a commit to phetsims/graphing-slope-intercept that referenced this issue Apr 19, 2024
@pixelzoom
Copy link
Contributor Author

Credits were updated and cherry picked in the above commits. Screenshots below. Ready for verification in RC2.

screenshot_3234 screenshot_3233

@amanda-phet
Copy link
Contributor

@pixelzoom did you see my comments above?

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 19, 2024

@pixelzoom did you see my comments above?

Yes. Right after I completed QA updates and cherry picks :(

It seems like there's some confusion about the Graphic Arts credits. This should have been resolved before the first RC test, because images have not changed, and code changes become expensive when release branches need to be patched. So I'm going to wait until @amanda-phet has sorted this out before proceeding with the next RC.

For GSI, 'Amanda McGarry' is already credited in 'Lead Design', and we typically do not credit someone twice.

@amanda-phet please tell me exactly what you'd like for the 'Graphic Arts' credits in GL and GSI. This blocks RC2.

@amanda-phet
Copy link
Contributor

We need to add Mariah to graphic arts, as she drew all the characters for the other regions. I'm not sure what Megan did, but she's listed in the published version so it's fine to keep her.

You're right, I'm already listed so don't worry about adding me.

@amanda-phet amanda-phet assigned pixelzoom and unassigned amanda-phet Apr 19, 2024
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 19, 2024

In #123 (comment) on 2/12/2019, @amanda-phet requested to add 'Megan Lai' to the 'Graphic Arts' credits. I don't know why -- checking out a snapshot of graphing-lines from that time, I do not see any image files attributed to 'Megan Lai'. Should I remove her?

@amanda-phet
Copy link
Contributor

It's possible she re-drew the phet girl level selection artwork, but Sharon was the original artist? I'm not sure it's worth digging, and since you found that request I'm sure there was a reason for it. I'm listed for graphic arts in other sims where I wasn't the artist, but spent considerable time on artwork.

Let's just add Mariah. Thanks.

pixelzoom added a commit to phetsims/graphing-slope-intercept that referenced this issue Apr 19, 2024
pixelzoom added a commit that referenced this issue Apr 19, 2024
pixelzoom added a commit that referenced this issue Apr 19, 2024
pixelzoom added a commit to phetsims/graphing-slope-intercept that referenced this issue Apr 19, 2024
@pixelzoom
Copy link
Contributor Author

Updated to 'Graphic Arts' credits were made in main and cherry picked in the above commits. Screenshots shown below. @amanda-phet please review, assign back to me if OK.

screenshot_3235 screenshot_3236

@pixelzoom pixelzoom removed their assignment Apr 19, 2024
@amanda-phet
Copy link
Contributor

Looks good. Thanks.

@amanda-phet amanda-phet assigned pixelzoom and unassigned amanda-phet Apr 19, 2024
@pixelzoom
Copy link
Contributor Author

Ready for verification in RC2.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 22, 2024

Ready for review in GL 1.4.0-rc2 and GSI 1.2.0-rc2.

@Nancy-Salpepi
Copy link

QA credits have been updated (boy are they long!) and Mariah has been added to the Graphic Arts section in both GL 1.4.0-rc.2 and GSI 1.2.0-rc.2.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants