-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update credits for 1.4 release #155
Comments
So far Nancy Salpepi and Jaron Droder should be added. |
phetsims/qa#1066 and phetsims/qa#1067 RC1 tests have been completed. Before I deploy RC2... @KatieWoe is there anyone else I need to add other than Nancy Salpepi and Jaron Droder? |
Nancy Salpepi, Clifford Hardin, and Jaron Droder should be added. |
Please add Mariah Hermsmeyer and Amanda McGarry to graphic arts. |
I don't see artwork from Megan Lai... is she in a license somewhere? |
@pixelzoom did you see my comments above? |
Yes. Right after I completed QA updates and cherry picks :( It seems like there's some confusion about the Graphic Arts credits. This should have been resolved before the first RC test, because images have not changed, and code changes become expensive when release branches need to be patched. So I'm going to wait until @amanda-phet has sorted this out before proceeding with the next RC. For GSI, 'Amanda McGarry' is already credited in 'Lead Design', and we typically do not credit someone twice. @amanda-phet please tell me exactly what you'd like for the 'Graphic Arts' credits in GL and GSI. This blocks RC2. |
We need to add Mariah to graphic arts, as she drew all the characters for the other regions. I'm not sure what Megan did, but she's listed in the published version so it's fine to keep her. You're right, I'm already listed so don't worry about adding me. |
In #123 (comment) on 2/12/2019, @amanda-phet requested to add 'Megan Lai' to the 'Graphic Arts' credits. I don't know why -- checking out a snapshot of graphing-lines from that time, I do not see any image files attributed to 'Megan Lai'. Should I remove her? |
It's possible she re-drew the phet girl level selection artwork, but Sharon was the original artist? I'm not sure it's worth digging, and since you found that request I'm sure there was a reason for it. I'm listed for graphic arts in other sims where I wasn't the artist, but spent considerable time on artwork. Let's just add Mariah. Thanks. |
Updated to 'Graphic Arts' credits were made in main and cherry picked in the above commits. Screenshots shown below. @amanda-phet please review, assign back to me if OK. |
Looks good. Thanks. |
Ready for verification in RC2. |
Ready for review in GL 1.4.0-rc2 and GSI 1.2.0-rc2. |
QA credits have been updated (boy are they long!) and Mariah has been added to the Graphic Arts section in both GL 1.4.0-rc.2 and GSI 1.2.0-rc.2. |
For #142 ...
@KatieWoe please identify QA credit updates in this issue.
The current credits are:
The text was updated successfully, but these errors were encountered: