dispose instances of RichDragListener, #153

(cherry picked from commit ccc67e1)

js/common/view/PointToolNode.ts

@@ -120,13 +120,15 @@ export default class PointToolNode extends Node {
       } );
 
     // interactivity
-    this.addInputListener( new PointToolDragListener( this, pointTool, modelViewTransform, graph ) );
+    const dragListener = new PointToolDragListener( this, pointTool, modelViewTransform, graph );
+    this.addInputListener( dragListener );
 
     this.disposePointToolNode = () => {
       updateMultilink.dispose();
       bodyNode.dispose();
       probeNode.dispose();
       coordinatesProperty.dispose();
+      dragListener.dispose();
     };
   }
 

js/common/view/manipulator/PointManipulator.ts

@@ -38,10 +38,12 @@ export default class PointManipulator extends Manipulator {
     };
     pointProperty.link( lineObserver ); // unlink in dispose
 
-    this.addInputListener( new PointDragListener( this, pointProperty, otherPointProperties, xRange, yRange, modelViewTransform ) );
+    const dragListener = new PointDragListener( this, pointProperty, otherPointProperties, xRange, yRange, modelViewTransform );
+    this.addInputListener( dragListener );
 
     this.disposePointManipulator = () => {
       pointProperty.unlink( lineObserver );
+      dragListener.dispose();
     };
   }
 

js/common/view/manipulator/SlopeManipulator.ts

@@ -37,10 +37,12 @@ export default class SlopeManipulator extends Manipulator {
     };
     lineProperty.link( lineObserver ); // unlink in dispose
 
-    this.addInputListener( new SlopeDragListener( this, lineProperty, riseRangeProperty, runRangeProperty, modelViewTransform ) );
+    const dragListener = new SlopeDragListener( this, lineProperty, riseRangeProperty, runRangeProperty, modelViewTransform );
+    this.addInputListener( dragListener );
 
     this.disposeSlopeManipulator = () => {
       lineProperty.unlink( lineObserver );
+      dragListener.dispose();
     };
   }
 

js/common/view/manipulator/X1Y1Manipulator.ts

@@ -46,10 +46,12 @@ export default class X1Y1Manipulator extends Manipulator {
     };
     lineProperty.link( lineObserver ); // unlink in dispose
 
-    this.addInputListener( new X1Y1DragListener( this, lineProperty, x1RangeProperty, y1RangeProperty, modelViewTransform, constantSlope ) );
+    const dragListener = new X1Y1DragListener( this, lineProperty, x1RangeProperty, y1RangeProperty, modelViewTransform, constantSlope );
+    this.addInputListener( dragListener );
 
     this.disposeX1Y1Manipulator = () => {
       lineProperty.unlink( lineObserver );
+      dragListener.dispose();
     };
   }
 

js/common/view/manipulator/X2Y2Manipulator.ts

@@ -37,10 +37,12 @@ export default class X2Y2Manipulator extends Manipulator {
     };
     lineProperty.link( lineObserver ); // unlink in dispose
 
-    this.addInputListener( new X2Y2DragListener( this, lineProperty, x2RangeProperty, y2RangeProperty, modelViewTransform ) );
+    const dragListener = new X2Y2DragListener( this, lineProperty, x2RangeProperty, y2RangeProperty, modelViewTransform );
+    this.addInputListener( dragListener );
 
     this.disposeX2Y2Manipulator = () => {
       lineProperty.unlink( lineObserver );
+      dragListener.dispose();
     };
   }
 

js/common/view/manipulator/YInterceptManipulator.ts

@@ -37,10 +37,12 @@ export default class YInterceptManipulator extends Manipulator {
     };
     lineProperty.link( lineObserver ); // unlink in dispose
 
-    this.addInputListener( new YInterceptDragListener( this, lineProperty, y1RangeProperty, modelViewTransform ) );
+    const dragListener = new YInterceptDragListener( this, lineProperty, y1RangeProperty, modelViewTransform );
+    this.addInputListener( dragListener );
 
     this.disposeYInterceptManipulator = () => {
       lineProperty.unlink( lineObserver );
+      dragListener.dispose();
     };
   }