-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fire/Ice sputters while changing Particle amount #283
Comments
Reproduced in main. What you're observing is the heater/cooler animation starting over, which happens whenever the number of particles changes. Relevant code is in GasPropertiesHeaterCoolerNode.ts |
@Nancy-Salpepi please review in main. Leave open for verification in 1.1.0-rc.2. |
Reminder to self that I need to cherry-pick 97f65d1 into gases-intro. It is irrelevant for diffusion. |
(cherry picked from commit 97f65d1)
(cherry picked from commit 97f65d1)
I decided that it's going to be easier to patch any changes to gas-properties into all 3 release branches, regardless of whether they are relevant to all 3 sims. So that's what I did in the commits above. |
Working nicely in main. |
Ready for verification in 1.1.0-rc.2. |
Please verify for phetsims/qa#1123 and phetsims/qa#1124. (This issue is irrelevant for the Diffusion sim). To verify, follow "Steps to reproduce" in #283 (comment). If everything looks OK, please close this issue. |
Looks good in rc.2 for Gas Properties and Gases Intro. |
Test device
MacBook Air M1 chip
Operating System
14.5
Browser
Chrome
Problem description
For phetsims/qa#1107 on the Ideal Screen with PressureT radio button selected, as I change the amount of particles the fire/ice will sputter the whole time I hold down an increment/decrement button. This doesn't happen in Published.
Steps to reproduce
Visuals
heaterCoolerNode.mp4
The text was updated successfully, but these errors were encountered: