Fire/Ice sputters while changing Particle amount

[Nancy-Salpepi]

Test device
MacBook Air M1 chip

Operating System
14.5

Browser
Chrome

Problem description
For phetsims/qa#1107 on the Ideal Screen with PressureT radio button selected, as I change the amount of particles the fire/ice will sputter the whole time I hold down an increment/decrement button. This doesn't happen in Published.

Steps to reproduce

1. On the Ideal Screen add some particles
2. Select the PressureT radio button
3. Press and hold any increment/decrement button for red/blue particles

Visuals

heaterCoolerNode.mp4

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Gas Properties‬ URL: https://phet-dev.colorado.edu/html/gas-properties/1.1.0-rc.1/phet/gas-properties_all_phet.html Version: 1.1.0-rc.1 2024-07-11 00:18:26 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Language: en-US Window: 1279x730 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}

[pixelzoom]

Reproduced in main.

What you're observing is the heater/cooler animation starting over, which happens whenever the number of particles changes. Relevant code is in GasPropertiesHeaterCoolerNode.ts startAnimation.

[pixelzoom]

Looks like this was introduced in df4dcfb for #227, where animation changes were made for PhET-iO compatibility.

[pixelzoom]

@Nancy-Salpepi please review in main. Leave open for verification in 1.1.0-rc.2.

[pixelzoom]

Reminder to self that I need to cherry-pick 97f65d1 into gases-intro. It is irrelevant for diffusion.

[pixelzoom]

I decided that it's going to be easier to patch any changes to gas-properties into all 3 release branches, regardless of whether they are relevant to all 3 sims. So that's what I did in the commits above.

[Nancy-Salpepi]

Working nicely in main.

[pixelzoom]

Ready for verification in 1.1.0-rc.2.

[pixelzoom]

Please verify for phetsims/qa#1123 and phetsims/qa#1124. (This issue is irrelevant for the Diffusion sim).

To verify, follow "Steps to reproduce" in #283 (comment).

If everything looks OK, please close this issue.

[Nancy-Salpepi]

Looks good in rc.2 for Gas Properties and Gases Intro.
Closing