Added TODOs, see #64

phetsims · Feb 13, 2018 · 07dad3c · 07dad3c
1 parent 657c534
commit 07dad3c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/js/friction/model/FrictionModel.js b/js/friction/model/FrictionModel.js
@@ -201,6 +201,7 @@ define( function( require ) {
     this.hintProperty = new Property( true );
 
     // @public (read-only)- update every step
+    // TODO: Use an emitter here
     this.newStepProperty = new Property( false );
 
     // @public (read-only) - drag and drop book coordinates conversion coefficient

diff --git a/js/friction/view/book/BookNode.js b/js/friction/view/book/BookNode.js
@@ -28,7 +28,7 @@ define( function( require ) {
   var bookTitleStringPattern = FrictionA11yStrings.bookTitleStringPattern.value;
 
   /**
-   * @param {FrictionModel} model
+   * @param {FrictionModel} model TODO: after making TODO changes below, maybe the entire model doesn't need to be passed in
    * @param {string} title - title that appears on the book spine
    * @param {Object} [options]
    * @constructor

diff --git a/js/friction/view/magnifier/AtomNode.js b/js/friction/view/magnifier/AtomNode.js
@@ -61,11 +61,14 @@ define( function( require ) {
       // Scale up before rasterization so it won't be too pixellated/fuzzy, value empirically determined.
       var scale = AtomNode.imageScale;
       var container = new Node( { scale: 1 / scale } );
+
+      // TODO: should we use shaded sphere?
       var atomNode = new Circle( radius, { fill: options.color, stroke: 'black', lineWidth: 1, scale: scale } );
       atomNode.addChild( new Circle( radius * 0.3, { fill: 'white', x: radius * 0.3, y: -radius * 0.3 } ) );
       atomNode.toImage( function( img, x, y ) {
 
         // add our actual HTMLImageElement to atomImages
+        // TODO: what is happening here?
         AtomNode.atomImages[ self.isTopAtom ] = img;
         AtomNode.atomOffset = new Vector2( -x, -y );