Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long Strings in Equality game overlap #68

Closed
KatieWoe opened this issue Jan 8, 2019 · 3 comments
Closed

Long Strings in Equality game overlap #68

KatieWoe opened this issue Jan 8, 2019 · 3 comments
Assignees
@KatieWoe
Labels
status:ready-for-review type:i18n

Comments

@KatieWoe
Copy link

KatieWoe commented Jan 8, 2019

When stringTest=long and playing the game, different strings are allowed to overlap. For phetsims/qa#251
Steps:

  1. Turn on the timer to see all strings
  2. Select any level

overlaps
jonathanolson added a commit that referenced this issue Jan 8, 2019
@jonathanolson
Some i18n maxWidths for fraction matcher code, see #68
37eaa29
@jonathanolson
Copy link
Contributor

Should be handled by the above commit.

@ariel-phet ariel-phet removed their assignment Jan 8, 2019
@KatieWoe
Copy link
Author

KatieWoe commented Jan 8, 2019

Looks good

@jonathanolson jonathanolson reopened this Jan 15, 2019
This was referenced Jan 16, 2019
Closed
Closed
Closed
Closed
@KatieWoe
Copy link
Author

Looks good 1.0.0-rc.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KatieWoe KatieWoe

Labels
status:ready-for-review type:i18n
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanolson @ariel-phet @KatieWoe