Skip to content

Commit

Permalink
document why NumberControl title is '', #165
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Sep 20, 2021
1 parent 0578974 commit c3931c7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions js/wavepacket/view/WavePacketNumberControl.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ class WavePacketNumberControl extends NumberControl {
tandem: Tandem.REQUIRED
}, FMWConstants.WAVE_PACKET_NUMBER_CONTROL_OPTIONS, options );

//REVIEW: Looks like the layoutFunction doesn't use the title, is that why the empty-string is passed here?
super( '' /* title */, numberProperty, numberProperty.range, options );
// The layoutFunction doesn't use the title, so provide empty string.
super( '', numberProperty, numberProperty.range, options );

// Make tick label interactive, so that pressing on a tick label sets the Property to that value.
if ( options.sliderOptions && options.sliderOptions.majorTicks ) {
Expand Down

0 comments on commit c3931c7

Please sign in to comment.