document why I'm using for instead of map, #165

phetsims · Sep 20, 2021 · a908c87 · a908c87
1 parent 93019fb
commit a908c87
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/js/discrete/view/FourierSoundGenerator.js b/js/discrete/view/FourierSoundGenerator.js
@@ -42,7 +42,9 @@ class FourierSoundGenerator extends SoundGenerator {
     );
 
     // {OscillatorSoundGenerator[]} Create an oscillator for each harmonic.
-    const oscillatorSoundGenerators = []; //REVIEW: = fourierSeries.harmonics.map( harmonic => ... )?
+    // Using for loop here instead of map, because we need to connect each OscillatorSoundGenerator to the
+    // masterGainNode, and map should not have side-effects.
+    const oscillatorSoundGenerators = [];
     for ( let i = 0; i < fourierSeries.harmonics.length; i++ ) {
       const harmonic = fourierSeries.harmonics[ i ];
       const oscillatorSoundGenerator = new OscillatorSoundGenerator( {