Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate 1.1 branch #253

Closed
pixelzoom opened this issue Jul 31, 2019 · 5 comments
Closed

investigate 1.1 branch #253

pixelzoom opened this issue Jul 31, 2019 · 5 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 31, 2019

Discovered during code review #247, discussed with @jbphet on Zoom.

The currently published version is 1.0.6.

A 1.1 branch was created on 3/15/19 by @chrisklus. It has an RC test issue, phetsims/qa#298, for 1.1.0-rc.2. And 1.1.0-rc.1 apparent doesn't exist because of a build server error. It appears that no sim-specific commits have been made on 1.1 since 3/15/19. It's not clear whether all commits made it into 1.0 and master.

Since so much has changed since 3/15/19, and since the next release will include brand=phet-io, the release process will likely be resumed on a new 1.2 branch, and 1.1 will be abandoned.

The QA issue for 1.1.0-rc.2 testing should probably be closed, see phetsims/qa#298 (comment).

@samreid
Copy link
Member

samreid commented Jul 31, 2019

Do we have a way to tell the maintenance release process to ignore abandoned branches?

@jbphet
Copy link
Contributor

jbphet commented Aug 1, 2019

@chrisklus and I talked and recalled what this branch was about and why it stalled. There were several issues that we wanted to address that involved some significant changes to the code and some changes to the functionality. All in all, the changes were significant enough that we decided to create a new minor release rather than a maintenance release. There was one outstanding issue that was assigned to me (#238) that has been low priority, and blocked the release from getting done. Since the priority of work on this sim has now increased, I think we should probably fix the issue, finish the 1.1 release, and then do the work on master to add phet-io. That seems to me to be the best way to avoid any future confusion about this.

@chrisklus
Copy link
Contributor

I think we should probably fix the issue, finish the 1.1 release, and then do the work on master to add phet-io. That seems to me to be the best way to avoid any future confusion about this.

Sounds great to me.

@chrisklus chrisklus removed their assignment Aug 1, 2019
@jbphet
Copy link
Contributor

jbphet commented Aug 6, 2019

Assigning the @chrisklus to close if and when he does that 1.1 release.

@jbphet jbphet assigned chrisklus and unassigned jbphet Aug 6, 2019
@chrisklus
Copy link
Contributor

We ended up abandoning 1.1 and have taken RC SHAs for 1.2, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants