Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dependencies from dependencies.json #246

Closed
chrisklus opened this issue Jul 31, 2019 · 2 comments
Closed

Remove unneeded dependencies from dependencies.json #246

chrisklus opened this issue Jul 31, 2019 · 2 comments
Assignees

Comments

@chrisklus
Copy link
Contributor

These are still included, and should be removed:

  "phet-io-wrapper-classroom-activity": {
    "sha": "64aff78db6605aa5317724d50fdb28bd9cf495e2",
    "branch": "master"
  },
  "phet-io-wrapper-hookes-law-energy": {
    "sha": "85ce21c31f4a533993c84dfe2cd769d70fb65ef1",
    "branch": "master"
  },
  "phet-io-wrapper-lab-book": {
    "sha": "fb5c98c155259e2bdd37eb64e30081017a6e1d09",
    "branch": "master"
  },
  "phet-io-wrappers": {
    "sha": "77bb43e04e8b747d7cdff815fac5e091badeaf24",
    "branch": "master"
  },
@chrisklus chrisklus self-assigned this Jul 31, 2019
@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 31, 2019

@chrisklus Maybe you mean that these dependencies are in the 1.1 release branch? I don't see these dependencies in master, and (as noted in #253) the next release is going to be on a new 1.2 release branch. So perhaps this issue can be closed?

@chrisklus
Copy link
Contributor Author

I don't see these dependencies in master

Right, thanks. I must have been on 1.1. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants