-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panning with keyboard navigation breaks when switching screens while a moveable object has focus #210
Comments
Good point, let's put this on hold until after #209 |
Same problem now that we have GrabDragInteraction. Not sure how to solve it. @jessegreenberg or @zepumph any recommendations how to investigate? |
One thing I noticed is that the focused Node has infinite Bounds. The AnimatedPanZoomListener won't be able to pan to keep that target in view. Every once in a while, I noticed the bounds become finite and the problem went away. I would see the focus highlight jostle a little bit and wrap tightly around the mass graphic. Then it would shift away. This might be related to #209 (comment) and #327 If the infinite bounds cannot be fixed, let me know and we can explore workarounds in scenery. |
Thanks for the lead @jessegreenberg. That was really helpful. This was the chunk of code that was breaking things: df2334f#diff-ef1ad0c1582c6f2a99055c4065e1a884457a370ee52ec8d8017cc7d79e679cdcL192-L195 This is fixed now. Closing. |
Test device
MacBook Air M1 chip
Operating System
14.5
Browser
Safari and Chrome
Problem description
For phetsims/qa#1095, on all sims and all screens, if I change screens using the mouse while a moveable object, such as a block or scale, has keyboard focus, when I return to that screen I am unable to pan with keyboard navigation.
This may be a moot point now since we are switching to grab drag interaction, but still thought I should report this.
Seems specific to these sims. I also tested FEL on main and didn't see this problem when moving the magnet.
Steps to reproduce
Here is an example:
Visuals
panningBroken.mp4
The text was updated successfully, but these errors were encountered: