-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selecting Material Y freezes the sim [Safari] #192
Comments
This patch identifies the area of the problem, I'll continue investigating: Subject: [PATCH] Whitespace, see https://github.com/phetsims/density-buoyancy-common/issues/189
---
Index: js/buoyancy/view/BuoyancyExploreScreenView.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/buoyancy/view/BuoyancyExploreScreenView.ts b/js/buoyancy/view/BuoyancyExploreScreenView.ts
--- a/js/buoyancy/view/BuoyancyExploreScreenView.ts (revision 35e9d20881fc236083bee6a6cc7682e3952a0032)
+++ b/js/buoyancy/view/BuoyancyExploreScreenView.ts (date 1718222999087)
@@ -114,7 +114,7 @@
mass.volumeProperty.value = 0.003;
}
else if ( material === Material.MATERIAL_Y ) {
- mass.volumeProperty.value = 0.001;
+ mass.volumeProperty.value = 0.003;
}
} );
} ); |
@zepumph and I saw that the change to Property to make it queue-based caused the locks to fail. We experimented that changing to stack-based solved the problem, but we also saw that rounding to TOLERANCE was another way to short circuit the cycles because they seemed caused by rounding errors. I'll commit momentarily. |
Migration tests are working well, fuzz tests are working well, safari is no longer crashing under material Y. I sneaked in deleting some unused intersection code. Closing. |
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
Yes thanks. This code here is buggy without ensuring that we eagerly call the listeners during the lock. density-buoyancy-common/js/buoyancy/view/applications/BuoyancyApplicationsScreenView.ts Lines 123 to 133 in b4d88d1
|
Test device
MacBook Air M1 chip
Operating System
14.5
Browser
Safari 17.5
Problem description
For phetsims/qa#1095, seen with Safari but not Chrome:
Choosing Material Y on the Explore Screen freezes the sim. If I reload the sim, nothing is clickable. I have to open a new tab or window.
This doesn't happen with the other mystery materials.
Nothing appeared in the console.
Steps to reproduce
Visuals
mysteryObjectY.mp4
The text was updated successfully, but these errors were encountered: