rename GraphEquationAccordionBox to EquationAccordionBox, #143

phetsims · Aug 29, 2019 · bad189a · bad189a
1 parent b51005c
commit bad189a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 14 deletions.
diff --git a/js/curve-fitting/view/CurveFittingScreenView.js b/js/curve-fitting/view/CurveFittingScreenView.js
@@ -17,8 +17,8 @@ define( require => {
   const CurveFittingConstants = require( 'CURVE_FITTING/curve-fitting/CurveFittingConstants' );
   const CurveNode = require( 'CURVE_FITTING/curve-fitting/view/CurveNode' );
   const DeviationsAccordionBox = require( 'CURVE_FITTING/curve-fitting/view/DeviationsAccordionBox' );
+  const EquationAccordionBox = require( 'CURVE_FITTING/curve-fitting/view/EquationAccordionBox' );
   const GraphAreaNode = require( 'CURVE_FITTING/curve-fitting/view/GraphAreaNode' );
-  const GraphEquationAccordionBox = require( 'CURVE_FITTING/curve-fitting/view/GraphEquationAccordionBox' );
   const ModelViewTransform2 = require( 'PHETCOMMON/view/ModelViewTransform2' );
   const Rectangle = require( 'SCENERY/nodes/Rectangle' );
   const ResetAllButton = require( 'SCENERY_PHET/buttons/ResetAllButton' );
@@ -92,7 +92,7 @@ define( require => {
 
       // create the equation node (accordion box) in the upper left corner of the graph
       const equationBoxLeft = modelViewTransform.modelToViewX( -10 ) + 10;
-      const graphEquationAccordionBox = new GraphEquationAccordionBox(
+      const equationAccordionBox = new EquationAccordionBox(
         model.curve,
         model.orderProperty,
         equationPanelExpandedProperty,
@@ -104,18 +104,18 @@ define( require => {
         }
       );
 
-      // create the panel that serves as an opaque background for the graphEquationAccordionBox; see #126
-      // no dispose necessary because graphEquationAccordionBox is present for the lifetime of the sim
+      // create the panel that serves as an opaque background for the equationAccordionBox; see #126
+      // no dispose necessary because equationAccordionBox is present for the lifetime of the sim
       const graphEquationBackground = new Rectangle( 0, 0, 0, 0, 0, 0, {
         cornerRadius: CurveFittingConstants.PANEL_CORNER_RADIUS,
         fill: 'white'
       } );
-      graphEquationAccordionBox.updatedEmitter.addListener( () => {
-        graphEquationBackground.visible = graphEquationAccordionBox.visible;
-        graphEquationBackground.rectBounds = graphEquationAccordionBox.bounds;
+      equationAccordionBox.updatedEmitter.addListener( () => {
+        graphEquationBackground.visible = equationAccordionBox.visible;
+        graphEquationBackground.rectBounds = equationAccordionBox.bounds;
       } );
 
-      // Whenever the curve becomes visible, points below the GraphEquationAccordionBox's expand/collapse button get
+      // Whenever the curve becomes visible, points below the EquationAccordionBox's expand/collapse button get
       // pushed out from under the button; see #131
       const bumpOutPointsUnderExpandCollapseButton = () => {
         if ( !curveVisibleProperty.value ) {
@@ -124,8 +124,8 @@ define( require => {
 
         const pointPushBounds = modelViewTransform.viewToModelBounds(
           graphAreaNode.globalToLocalBounds(
-            graphEquationAccordionBox.expandCollapseButton.localToGlobalBounds(
-              graphEquationAccordionBox.expandCollapseButton.localBounds
+            equationAccordionBox.expandCollapseButton.localToGlobalBounds(
+              equationAccordionBox.expandCollapseButton.localBounds
             )
           )
         ).dilated( EXPAND_COLLAPSE_PUSH_BOUNDS_DILATION );
@@ -195,7 +195,7 @@ define( require => {
       this.addChild( curveNode );
       this.addChild( residualsNode );
       this.addChild( bucketNode );
-      this.addChild( graphEquationAccordionBox );
+      this.addChild( equationAccordionBox );
     }
 
   }

diff --git a/...fitting/view/GraphEquationAccordionBox.js → ...urve-fitting/view/EquationAccordionBox.js b/...fitting/view/GraphEquationAccordionBox.js → ...urve-fitting/view/EquationAccordionBox.js
@@ -1,7 +1,8 @@
 // Copyright 2015-2019, University of Colorado Boulder
 
 /**
- * Node with equation parameters in 'Curve Fitting' simulation.
+ * EquationAccordionBox is the accordion box that shows the equation of the curve on the graph.
+ * It displays 'undefined' if the curve is undefined.
  *
  * @author Andrey Zelenkov (Mlearner)
  * @author Saurabh Totey
@@ -28,7 +29,7 @@ define( require => {
   // max number of digits for coefficients in ascending order of polynomials
   const MAX_DIGITS = [ 2, 3, 4, 4 ];
 
-  class GraphEquationAccordionBox extends Panel {
+  class EquationAccordionBox extends Panel {
 
     /**
      * @param {Curve} curve
@@ -154,5 +155,5 @@ define( require => {
 
   }
 
-  return curveFitting.register( 'GraphEquationAccordionBox', GraphEquationAccordionBox );
+  return curveFitting.register( 'EquationAccordionBox', EquationAccordionBox );
 } );