Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent screen names #65

Closed
Denz1994 opened this issue Aug 31, 2018 · 1 comment
Closed

Inconsistent screen names #65

Denz1994 opened this issue Aug 31, 2018 · 1 comment
Assignees
@mbarlow12
Labels
dev:code-review

Comments

@Denz1994
Copy link
Contributor

As noted in #63:

Do filenames use an appropriate prefix?

CLMacroScreen.js and CLAtomicScreen.js are inconsistent with the rest of the file names, which use the extend name of the sim (i.e. CoulombsLawGlobalOptionsNode.js). These file names should be changed @mbarlow12.
mbarlow12 added a commit that referenced this issue Sep 25, 2018
@mbarlow12
atomic/macro screen names changed (see #65), atomic/macro screen scre…
d063d4e 
…en names and variables updated, (see #68)
@mbarlow12
Copy link
Contributor

Updated file names per @Denz1994 suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbarlow12 mbarlow12

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbarlow12 @Denz1994