Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Credits #64

Closed
Denz1994 opened this issue Aug 29, 2018 · 8 comments
Closed

Update Credits #64

Denz1994 opened this issue Aug 29, 2018 · 8 comments
Assignees
@KatieWoe
Labels
priority:2-high status:blocks-sim-publication

Comments

@Denz1994
Copy link
Contributor

Created during the review of Coulombs-Law in #63 so we don't forget to update credits as needed.
@arouinfar
Copy link
Contributor

The design credits are up to date, but Amy Hanson's last name has been misspelled. It should be Hanson with an 'o'.

QA credits will undoubtably expand, so this issue should be reassigned to @KatieWoe when we move into testing.

mbarlow12 added a commit that referenced this issue Sep 25, 2018
@mbarlow12
Hansen -> Hanson, TODO added for QA credits, see #64
d91df4a
@mbarlow12
Copy link
Contributor

Changed Amy's last name and added a TODO for QA credits. Closing.

@arouinfar
Copy link
Contributor

Since we're in RC, @KatieWoe should confirm the QA credits.

@arouinfar arouinfar reopened this Nov 6, 2018
@arouinfar arouinfar assigned KatieWoe and unassigned mbarlow12 Nov 6, 2018
@KatieWoe KatieWoe assigned mbarlow12 and unassigned KatieWoe Nov 6, 2018
@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 6, 2018

@mbarlow12 please add Katie Woessner and Laura Rea please.

mbarlow12 added a commit that referenced this issue Nov 7, 2018
@mbarlow12
credits updated, see #64
01e9320
mbarlow12 added a commit that referenced this issue Nov 7, 2018
@mbarlow12
credits updated, see #64
9af9b75
@mbarlow12 mbarlow12 assigned KatieWoe and unassigned mbarlow12 Nov 14, 2018
@mbarlow12
Copy link
Contributor

See links for fixes:
https://phet-dev.colorado.edu/html/coulombs-law/1.0.0-rc.5/phet/coulombs-law_en_phet.html
phetsims/qa#221

@KatieWoe KatieWoe assigned mbarlow12 and unassigned KatieWoe Nov 14, 2018
@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 14, 2018 •
edited
Loading

Looks good @mbarlow12
Edit: Actually, wait for this, incase more testers work on this rc. Sorry about that.

@KatieWoe KatieWoe assigned KatieWoe and unassigned mbarlow12 Nov 14, 2018
@phet-steele
Copy link

QA credits should still be alphabetized by last name (like all of our other sims).

arouinfar added a commit that referenced this issue Dec 22, 2018
@arouinfar
Finalize QA credits #64
dbe6719
arouinfar added a commit that referenced this issue Dec 22, 2018
@arouinfar
Finalize QA credits #64
6b93ce4
arouinfar added a commit that referenced this issue Dec 22, 2018
@arouinfar
Finalize QA credits #64
dc0fd1f
@arouinfar
Copy link
Contributor

QA credits have been alphabetized and updated to add testers from rc.6 onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KatieWoe KatieWoe

Labels
priority:2-high status:blocks-sim-publication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mbarlow12 @phet-steele @arouinfar @Denz1994 @KatieWoe