-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review ?showPointerAreas #142
Comments
I did all of the suggestions in the commit above. Assigning @arouinfar and @ariel-phet for review. |
Spoke with @ariel-phet on zoom. Pointer areas look good except for the number of balls number picker and the mass sliders, where this is some vertical overlap in pointer areas. Addressing that now. |
@brandonLi8 the pointer areas are generally looking good to me. The only device I can test touch areas on is my phone, which I can do if you publish a dev version (no VPN to access master on my phone). |
Overlap removed in the commit above. @ariel-phet @arouinfar please review in https://phet-dev.colorado.edu/html/collision-lab/1.1.0-dev.1/phet/collision-lab_en_phet.html |
@brandonLi8 I reviewed on my phone. All looking quite good but I do have 2 requested tweaks:
|
Done in the commit above. Restart Button: @ariel-phet @arouinfar please review in https://phet-dev.colorado.edu/html/collision-lab/1.1.0-dev.3/phet/collision-lab_en_phet.htm |
All looks good. Closing! |
@brandonLi8 it would be good to review ?showPointerAreas and likely expand a few "touch areas" where possible
For instance, the "reset collisions" button could have a dilated touch area, and I think if possible it would be good to expand the "More Data" checkbox touch area and such.
Could you take a first pass at this and then assign @arouinfar and I to review?
The text was updated successfully, but these errors were encountered: