Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development Checklist #50

Closed
14 of 16 tasks
samreid opened this issue Jun 13, 2017 · 4 comments
Closed
14 of 16 tasks

Development Checklist #50

samreid opened this issue Jun 13, 2017 · 4 comments

Comments

@samreid
Copy link
Member

samreid commented Jun 13, 2017

@samreid samreid self-assigned this Jun 13, 2017
@samreid
Copy link
Member Author

samreid commented Jun 27, 2017

@ariel-phet I would like to confirm the ordering of initial Dev QA testing and initial code review. Do you want to do dev testing first or code review first?

UPDATE: and more generally, would you please review the checklist in this issue description and revise the order if anything is amiss?

@ariel-phet
Copy link

@samreid yes, dev testing should occur before code review. Dev testing may well reveal issues that require refactoring/changes. We like to ideally review code that is in a stable state, reasonably bug free, and unlikely to undergo many changes except for those raised by the review.

@samreid samreid removed their assignment Jul 25, 2017
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Jul 26, 2017
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Jul 26, 2017
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Jul 26, 2017
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Jul 26, 2017
@samreid
Copy link
Member Author

samreid commented Sep 7, 2017

I published http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.160/circuit-construction-kit-dc_en.html and will test it on a few browsers before giving to the QA team.

@samreid
Copy link
Member Author

samreid commented Oct 7, 2017

Since we are on dev testing and hopefully going into RC soon, this issue has served its usefulness, closing.

@samreid samreid closed this as completed Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants