Light Bulb icons look crummy on Edge

[samreid]

[samreid]

Discovered in #109

[samreid]

Mipmaps solved this same problem for firefox, but not on edge.

[samreid]

dev.117 tried to fix the navbar icon. it is better but still pretty bad (depends on exact screen size)

[samreid]

@jonathanolson what do you recommend here?

[jonathanolson]

Is that on a retina screen? I'm curious if it's not properly adjusting mipmaps (or is over-adjusting mipmaps) on Edge, and maybe a mipmap level adjustment would help.

[samreid]

It is a nonretina screen, how do I do a level adjustment?

[jonathanolson]

If it's WebGL, I'd need to look it up.

If it's SVG/Canvas, adjust the Image node's mipmapBias (see setMipmapBias docs, note default is currently -0.7).

[samreid]

Those are SVG, I'll give that a try

[jonathanolson]

Forgot that Edge forces default to Canvas (because of SVG rendering issues).

I tried (?) changing the mipmapBias a lot and I saw no change (so I'm going to wait to investigate at home to debug further)

[samreid]

I tried removing the "edge is only canvas" logic and everything looked beautiful.

The ellipses were even OK. Should we look into removing that workaround now? My edge is 40.15063.0.0

[phet-steele]

@samreid, maybe try the three test links at the top of this issue: phetsims/scenery#515

EDIT: or maybe not! Thought those were examples of a bug. Nonetheless, that's the issue that made Edge default to canvas I think.

[jonathanolson]

I see comments in https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/3723601/ that indicate some text issues may be fixed in "EdgeHTML 15 / Edge 40" which should be in the Win10 "creators" update.

I'd recommend some investigation to see if we can identify Edge versions where our canvas workarounds aren't needed, so that we don't introduce other problems (like this).

I'll look into testing on latest Edge, and our browser usage on the website.

[jonathanolson]

Looks like Edge 14.x is somewhat more common than Edge 15.x (with 13.x and 12.x trailing off quickly).

[samreid]

Cursory testing on edge 14 with svg looks legit

Though I did see one occurrence of an ellipsis about 20px to the left.

[samreid]

@jonathanolson determined that mipmaps are not used on canvas. We'll investigate adding that feature and it may address this problem (leaving renderer as canvas on Edge).

[samreid]

The scenery change looks great, here's the before/after: