Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When simulation speed gets too high, electrons slow down, not time #717

Open
KatieWoe opened this issue Aug 25, 2021 · 7 comments
Open

When simulation speed gets too high, electrons slow down, not time #717

KatieWoe opened this issue Aug 25, 2021 · 7 comments

Comments

@KatieWoe
Copy link
Contributor

Found while testing #678.
When the sim speed slows down, the electrons slow down, but not other aspects. Specifically, oscillations in cck:ac will occur at the same rate (.5 Hz, etc.) and so some circuits may look stopped if they have a normal current. This also means that the current graph is unchanged in this state.
shouldcurrent

@samreid
Copy link
Member

samreid commented Aug 25, 2021

@arouinfar what about changing the text from "Simulation speed reduced" to "Current animation speed reduced"?

@arouinfar
Copy link
Contributor

"Current animation speed reduced"

Sounds good to me @samreid.

@samreid
Copy link
Member

samreid commented Aug 26, 2021

Fixed in the commit (in English), thanks! What should we do about the 56 pre-existing translations?

@samreid samreid assigned arouinfar and unassigned samreid Aug 26, 2021
@arouinfar
Copy link
Contributor

arouinfar commented Aug 26, 2021

What should we do about the 56 pre-existing translations?

There is precedent for changed strings, but I don't remember the procedure. Perhaps consult with @jbphet to determine what steps need to be taken.

@arouinfar arouinfar assigned samreid and jbphet and unassigned arouinfar Aug 26, 2021
@samreid samreid removed their assignment Aug 27, 2021
@jbphet
Copy link
Contributor

jbphet commented Aug 31, 2021

If I understand the situation correctly, you're only changing the value of the English string, and not changing the key. In that case, you could let all the translators know and they could make an update if they so desire. I usually do this by putting a list of the translated locales in the GitHub issue (i.e. this issue) and assigning it to @oliver-phet, and he emails the translators. It's up to you whether you think this change is something that is important enough that it should be captured in the translations.

If I've missed something and a string key is changing, there is document that describes the (very manual) process to make such a change, see https://github.com/phetsims/rosetta/blob/master/doc/how-to-change-a-string-key.md.

@jbphet jbphet assigned samreid and unassigned jbphet Aug 31, 2021
@samreid
Copy link
Member

samreid commented Aug 31, 2021

@arouinfar can you please review @jbphet's recommendation and advise?

@samreid samreid assigned arouinfar and unassigned samreid Aug 31, 2021
@samreid samreid added this to the AC 1.0 milestone Aug 31, 2021
@samreid
Copy link
Member

samreid commented Sep 2, 2021

At today's design meeting, we decided to inform the translators. We will do this after publication.

@samreid samreid removed this from the AC 1.0 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants