-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When simulation speed gets too high, electrons slow down, not time #717
Comments
@arouinfar what about changing the text from "Simulation speed reduced" to "Current animation speed reduced"? |
Sounds good to me @samreid. |
Fixed in the commit (in English), thanks! What should we do about the 56 pre-existing translations? |
There is precedent for changed strings, but I don't remember the procedure. Perhaps consult with @jbphet to determine what steps need to be taken. |
If I understand the situation correctly, you're only changing the value of the English string, and not changing the key. In that case, you could let all the translators know and they could make an update if they so desire. I usually do this by putting a list of the translated locales in the GitHub issue (i.e. this issue) and assigning it to @oliver-phet, and he emails the translators. It's up to you whether you think this change is something that is important enough that it should be captured in the translations. If I've missed something and a string key is changing, there is document that describes the (very manual) process to make such a change, see https://github.com/phetsims/rosetta/blob/master/doc/how-to-change-a-string-key.md. |
@arouinfar can you please review @jbphet's recommendation and advise? |
At today's design meeting, we decided to inform the translators. We will do this after publication. |
Found while testing #678.
When the sim speed slows down, the electrons slow down, but not other aspects. Specifically, oscillations in cck:ac will occur at the same rate (.5 Hz, etc.) and so some circuits may look stopped if they have a normal current. This also means that the current graph is unchanged in this state.
The text was updated successfully, but these errors were encountered: