Converted isNaN to isFinite, see #317

phetsims · Aug 23, 2017 · 4492b82 · 4492b82
1 parent 6d8cafc
commit 4492b82
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/js/model/Charge.js b/js/model/Charge.js
@@ -112,8 +112,7 @@ define( function( require ) {
      * @public
      */
     setLocation: function( circuitElement, distance ) {
-      //REVIEW: Are infinite distances allowed? isFinite() may be preferred over isNaN (but it's mostly a preference)
-      assert && assert( !isNaN( distance ), 'Distance was NaN' );
+      assert && assert( !isFinite( distance ), 'Distance was not finite' ); // also guards against NaN
       assert && assert( circuitElement.containsScalarLocation( distance ), 'no location in branch' );
       this.circuitElement = circuitElement;
       this.distanceProperty.set( distance );