Make tsc external tool links clickable in WebStorm.

[samreid]

As noted in #1173 (comment) it is convenient to trigger tsc from a keystroke in WebStorm and see the results below. It currently looks like this:

Note the filename is not hyperlinked like it is for lint:

Let's investigate making these links clickable in the IDE, perhaps by using output filters or by figuring out how lint is hyperlinked.

[samreid]

Same problem noted in https://github.com/microsoft/TypeScript/issues/7238#issuecomment-190436239 and https://youtrack.jetbrains.com/issue/IDEA-48163/External-Tools-no-evident-way-to-set-filter-that-allows-to-navig

[samreid]

After the commits, this is working well and I would like to share it with the dev team tomorrow.

[zepumph]

I wonder if we can make this have a default directory of your cwd.

[samreid]

I wonder if we can make this have a default directory of your cwd.

It sounds like you are describing a use case outside of running in WebStorm, like running from the command line. Can you please clarify?

[zepumph]

like running from the command line. Can you please clarify?

Yes, that is what I was saying. I think that this is not that useful though. The purpose of this file is for webstorm. Let's just use your info with no need for updates.

[samreid]

The changes from @zepumph are working well. I noticed an unrelated problem that getting a type error in the sim where the command is run from, doesn't make an absolute path because there are no '../' to detect. I'm seeing output like:

node perennial/js/scripts/absolute-tsc.js mean-share-and-balance/ ../
js/leveling-out/model/LevelingOutModel.ts(73,5): error TS2322: Type 'PhetioGroup<WaterCupModel, [x: string]>' is not assignable to type 'PhetioGroup<WaterCupModel, [x: number]>'.

[samreid]

Implemented and works great on both my mac and windows. @zepumph can you please test drive it on yours? Close if all is well. Also note the 2nd command line arg no longer necessary.

[zepumph]

Works great! Thanks for the improvement. No other thoughts here.