Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TypeScript for every repo so it can be used in common code #1148

Closed
4 of 5 tasks
samreid opened this issue Nov 18, 2021 · 3 comments
Closed
4 of 5 tasks

Enable TypeScript for every repo so it can be used in common code #1148

samreid opened this issue Nov 18, 2021 · 3 comments

Comments

@samreid
Copy link
Member

samreid commented Nov 18, 2021

At today's dev meeting, we agreed to enable typescript for every repo so it can be used in common code.

In slack, I said:

grunt update is set to create a *.ts string file for repos that have typescript enabled. Can I output the *.ts strings for all repos? Or do we want that to remain *.js in the majority of repos?

It seems best to keep things consistent, and I’m seeing the *.ts file can be used nicely in *.js files. So I’ll plan to go forward with *.ts string files unless/until I hear otherwise.

@jonathanolson replied:

Sounds good to me

Here are some steps:

  • Remove isRepoTypeScript
  • grunt update sims
  • Add phet-types.d.ts to tsconfigs
  • Message the google group.
  • Message the slack channel.
@samreid samreid self-assigned this Nov 18, 2021
samreid added a commit to phetsims/perennial that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/acid-base-solutions that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/area-model-common that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/arithmetic that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/area-builder that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/atomic-interactions that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/axon that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/area-model-algebra that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/beers-law-lab that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/blast that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/balancing-act that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/build-a-fraction that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/build-a-nucleus that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/balloons-and-static-electricity that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/bamboo that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/area-model-decimals that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/balancing-chemical-equations that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/bumper that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/blackbody-spectrum that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/build-a-molecule that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/buoyancy that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/area-model-introduction that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/bending-light that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/brand that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/charges-and-fields that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/area-model-multiplication that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/vibe that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/vector-addition-equations that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/wave-interference that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/wave-on-a-string that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/sun that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/xray-diffraction that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/wilder that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/vector-addition that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/waves-intro that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/density-buoyancy-common that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/equality-explorer that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/geometric-optics that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/gravity-force-lab-basics that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/joist that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/normal-modes that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/number-play that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/phet-info that referenced this issue Nov 19, 2021
samreid added a commit to phetsims/ratio-and-proportion that referenced this issue Nov 19, 2021
@samreid
Copy link
Member Author

samreid commented Nov 19, 2021

Add phet-types.d.ts to tsconfigs

I'm not sure that step is necessary, and not sure how to test.

@zepumph or @jonathanolson can you please review the chipper and perennial commits, and spot check 1-2 sim repo commits?

@samreid samreid assigned jonathanolson and zepumph and unassigned samreid Nov 19, 2021
@jonathanolson
Copy link
Contributor

Commits look good based on my understanding. getStringMap whitespace dependency sounds tricky, if we change how the code is formatted under chipper/dist (but looks correct for behavior right now).

@samreid
Copy link
Member Author

samreid commented Nov 20, 2021

Thanks, closing.

@samreid samreid closed this as completed Nov 20, 2021
samreid added a commit to phetsims/phet-info that referenced this issue Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants